18F/analytics-reporter

View on GitHub

Showing 4 of 73 total issues

Function calculateTotals has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const calculateTotals = (result) => {
  if (result.data.length === 0) {
    return result;
  }

Severity: Major
Found in ua/src/process-results/result-totals-calculator.js - About 4 hrs to fix

    Function calculateTotals has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const calculateTotals = (result) => {
      if (result.data.length === 0) {
        return {};
      }
    
    
    Severity: Major
    Found in src/process-results/result-totals-calculator.js - About 3 hrs to fix

      Function calculateTotals has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

      const calculateTotals = (result) => {
        if (result.data.length === 0) {
          return {};
        }
      
      
      Severity: Minor
      Found in src/process-results/result-totals-calculator.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function calculateTotals has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

      const calculateTotals = (result) => {
        if (result.data.length === 0) {
          return result;
        }
      
      
      Severity: Minor
      Found in ua/src/process-results/result-totals-calculator.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language