Sign upLogin

18F/dolores-landingham-slack-bot

View on GitHub
Star

Showing 8 of 346 total issues

Function elastic has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        elastic: function() {

            //    We will create a div clone of the textarea
            //    by copying these attributes from the textarea to the div.
            var mimics = [
Severity: Major
Found in vendor/assets/javascripts/elastic.js - About 3 hrs to fix

    File components.js has 276 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

/* globals $: false */
    Severity: Minor
    Found in app/assets/javascripts/components.js - About 2 hrs to fix

      Method run has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run
    slack_user_id = EmployeeFinder.new(employee.slack_username).slack_user_id

    if employee.slack_user_id.nil? && slack_user_id.present?
      employee.slack_user_id = slack_user_id
      Severity: Minor
      Found in app/services/message_sender.rb - About 1 hr to fix

        Method up has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def up
    # Create tables for new models
    create_table :onboarding_messages do |t|
      t.timestamps null: false
      t.string :title, null: false
        Severity: Minor
        Found in db/migrate/20160920181736_split_scheduled_messages_into_onboarding_messages_and_quarterly_messages.rb - About 1 hr to fix

          Function validator has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          function validator($el) {
  var data = $('#password[data-validation-element]').data(),
      key,
      validatorName,
      validatorPattern,
          Severity: Minor
          Found in app/assets/javascripts/components.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _divideIntoArray has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              Politespace.prototype._divideIntoArray = function( value ) {
        var split = ( '' + this.groupLength ).split( ',' ),
            isUniformSplit = split.length === 1,
            dividedValue = [],
            loopIndex = 0,
          Severity: Minor
          Found in app/assets/javascripts/components.js - About 1 hr to fix

            Method filter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def self.filter(params)
    if params[:slack_username].present? ||
        params[:message_body].present? ||
        params[:sent_on].present?
            Severity: Minor
            Found in app/models/sent_message.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def run
    slack_user_id = EmployeeFinder.new(employee.slack_username).slack_user_id

    if employee.slack_user_id.nil? && slack_user_id.present?
      employee.slack_user_id = slack_user_id
            Severity: Minor
            Found in app/services/message_sender.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language