Sign upLogin

18F/e-QIP-prototype

View on GitHub
Star
api/http/save.go

Summary

Maintainability
A
1 hr
Test Coverage

Avoid deeply nested control flow statements.
Open

                    if saveAgainErr != nil {
                        // this time, nothing will save you.
                        service.Log.WarnError(api.EntitySaveError, saveAgainErr, api.LogFields{})
                        RespondWithStructuredError(w, api.EntitySaveError, http.StatusInternalServerError)
                        return
Severity: Major
Found in api/http/save.go - About 45 mins to fix

    Method SaveHandler.ServeHTTP has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
    Open

    func (service SaveHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {

    // Get account information
    account, _ := AccountAndSessionFromRequestContext(r)
    Severity: Minor
    Found in api/http/save.go - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status