Sign upLogin

18F/e-QIP-prototype

View on GitHub
Star
api/xml/xml.go

Summary

Maintainability
C
1 day
Test Coverage

File xml.go has 988 lines of code (exceeds 750 allowed). Consider refactoring.
Open

package xml

import (
    "bytes"
    "encoding/json"
Severity: Major
Found in api/xml/xml.go - About 7 hrs to fix

    Method applicationPackager.locationOverrideLayout has 19 return statements (exceeds 10 allowed).
    Open

    func (p applicationPackager) locationOverrideLayout(data map[string]interface{}, override string) (template.HTML, error) {
    // Deserialize the initial payload from a JSON structure
    payload := &api.Payload{}
    // entity, err := payload.UnmarshalEntity(getInterfaceAsBytes(data))
    entity, err := payload.UnmarshalEntity(getInterfaceAsBytes(data))
    Severity: Major
    Found in api/xml/xml.go - About 1 hr to fix

      Method applicationPackager.locationOverrideLayout has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
      Open

      func (p applicationPackager) locationOverrideLayout(data map[string]interface{}, override string) (template.HTML, error) {
    // Deserialize the initial payload from a JSON structure
    payload := &api.Payload{}
    // entity, err := payload.UnmarshalEntity(getInterfaceAsBytes(data))
    entity, err := payload.UnmarshalEntity(getInterfaceAsBytes(data))
      Severity: Minor
      Found in api/xml/xml.go - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status