Showing 6 of 8 total issues
Method input
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def input
template.content_tag(:div, :class => @input_html_classes.select {|c| c =~ /span[1-9]+/}.push('uploadable-input')) do
result = ''
result += template.content_tag(:ul, :class => 'uploadable-nav') do
Method alipay_notify
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def alipay_notify
notify_params = params.except(*request.path_parameters.keys)
if Alipay::Sign.verify?(notify_params) && Alipay::Notify.verify?(notify_params)
@order = EventOrder.find params[:id]
if ['TRADE_SUCCESS', 'TRADE_FINISHED'].include?(params[:trade_status])
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method time_merge
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def time_merge(event)
start_time = event.start_time
end_time = event.end_time
text = start = I18n.localize(start_time, :format => format_year(start_time)) # http://j.mp/11ycCAB
unless end_time.nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method alipay_notify
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def alipay_notify
notify_params = params.except(*request.path_parameters.keys)
if Alipay::Notify.verify?(notify_params)
EventOrder.transaction do
refund_batch = RefundBatch.where(batch_no: params[:batch_no]).first
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method tab_for
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def tab_for(tab, name, path, current_path, item_options = {})
Method init_event_order_fulfillments
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def init_event_order_fulfillments(orders = @orders)
orders = Jbuilder.new do |json|
json.array! orders do |order|
json.(order, :id, :number, :paid_amount)
json.user order.user, :login, :email
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"