Sign upLogin

Acornsgrow/hitnmiss

View on GitHub
Star

Showing 3 of 7 total issues

Method set has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def set(key, entity)
      if entity.expiration
        expiration = epoch_time + entity.expiration
        @mutex.synchronize do
          @cache[key] = { 'value' => entity.value, 'expiration' => expiration }
Severity: Minor
Found in lib/hitnmiss/in_memory_driver.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method refresh has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def refresh(*args, swallow_exceptions: [])
        logger.debug("hitnmiss: refresh(#{args.inspect}, swallow_exceptions: #{swallow_exceptions.inspect}) called")
        if swallow_exceptions.empty?
          logger.debug("hitnmiss: refresh(#{args.inspect}, swallow_exceptions: #{swallow_exceptions.inspect}) about to check stale?")
          if stale?(*args)
Severity: Minor
Found in lib/hitnmiss/background_refresh_repository.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method all has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def all(keyspace)
      matching_values = []
      Dir["#{@folder}/*"].each do |filename|
        if match_keyspace?(File.basename(filename), keyspace)
          entity = read(filename)
Severity: Minor
Found in lib/hitnmiss/file_driver.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language