Sign upLogin

ActivityWatch/aw-server

View on GitHub
Star
aw_server/rest.py

Summary

Maintainability
A
4 hrs
Test Coverage

File rest.py has 308 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json
import traceback
from functools import wraps
from threading import Lock
from typing import Dict
Severity: Minor
Found in aw_server/rest.py - About 3 hrs to fix

    Function host_header_check has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def host_header_check(f):
    """
    Protects against DNS rebinding attacks (see https://github.com/ActivityWatch/activitywatch/security/advisories/GHSA-v9fg-6g9j-h4x4)

    Some discussion in Syncthing how they do it: https://github.com/syncthing/syncthing/issues/4819
    Severity: Minor
    Found in aw_server/rest.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status