ActivityWatch/aw-server

View on GitHub

Showing 3 of 3 total issues

Function parse_settings has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def parse_settings():
    import argparse

    """ CLI Arguments """
    parser = argparse.ArgumentParser(description='Starts an ActivityWatch server')
Severity: Minor
Found in aw_server/main.py - About 1 hr to fix

    Function detect_version has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def detect_version():
        basever = "v0.8"
    
        for env_var in ["TRAVIS_TAG", "APPVEYOR_REPO_TAG_NAME"]:
            if env_var in os.environ:
    Severity: Minor
    Found in aw_server/__about__.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return basever + "-dev-unknown"
    Severity: Major
    Found in aw_server/__about__.py - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language