AgileVentures/LocalSupport

View on GitHub
app/controllers/base_organisations_controller.rb

Summary

Maintainability
A
25 mins
Test Coverage
A
100%

Method has too many lines. [13/7] (https://github.com/bbatsov/ruby-style-guide#short-methods)
Open

  def build_map_markers(organisations)
    ::MapMarkerJson.build(organisations) do |org, marker|
      marker.lat org.latitude
      marker.lng org.longitude
      marker.infowindow render_to_string(partial: 'organisations/popup', locals: {org: org})

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method build_map_markers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def build_map_markers(organisations)
    ::MapMarkerJson.build(organisations) do |org, marker|
      marker.lat org.latitude
      marker.lng org.longitude
      marker.infowindow render_to_string(partial: 'organisations/popup', locals: {org: org})
Severity: Minor
Found in app/controllers/base_organisations_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line is too long. [92/90] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

      marker.infowindow render_to_string(partial: 'organisations/popup', locals: {org: org})

There are no issues that match your filters.

Category
Status