app/src/main/java/sdp/moneyrun/ui/game/GameLobbyActivity.java
GameLobbyActivity
has 23 methods (exceeds 20 allowed). Consider refactoring. Open
Open
@SuppressWarnings("FieldCanBeLocal")
public class GameLobbyActivity extends AppCompatActivity {
private final String TAG = GameLobbyActivity.class.getSimpleName();
private final String DB_IS_DELETED = "isDeleted";
private final String DB_PLAYERS = "players";
Method onDestroy
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
Open
@Override
protected void onDestroy() {
super.onDestroy();
DatabaseProxy.removeOfflineListener();
if (playerListListener != null)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File GameLobbyActivity.java
has 252 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
package sdp.moneyrun.ui.game;
import android.content.Intent;
import android.os.Bundle;
import android.util.Log;
Method listenToStarted
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
private void listenToStarted() {
if (!game.getHost().equals(player)) {
isStartedListener = new ValueEventListener() {
@Override
public void onDataChange(@NonNull DataSnapshot snapshot) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"