Sign upLogin

Alvaro2112/Money_run

View on GitHub
Star
app/src/main/java/sdp/moneyrun/ui/map/MapActivity.java

Summary

Maintainability
D
2 days
Test Coverage
A
90%

File MapActivity.java has 571 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package sdp.moneyrun.ui.map;

import android.Manifest;
import android.content.pm.PackageManager;
import android.graphics.Color;
Severity: Major
Found in app/src/main/java/sdp/moneyrun/ui/map/MapActivity.java - About 1 day to fix

    MapActivity has 53 methods (exceeds 20 allowed). Consider refactoring.
    Open

    @SuppressWarnings({"CanBeFinal", "FieldCanBeLocal"})
public class MapActivity extends TrackedMap implements OnMapReadyCallback {
    public static final int THRESHOLD_DISTANCE = 5;
    public static final float DISTANCE_CHANGE_BEFORE_UPDATE = (float) 2;
    private static final long MINIMUM_TIME_BEFORE_UPDATE = 2000;
    Severity: Major
    Found in app/src/main/java/sdp/moneyrun/ui/map/MapActivity.java - About 7 hrs to fix

      Method onButtonShowQuestionPopupWindowClick has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public void onButtonShowQuestionPopupWindowClick(View view, Boolean focusable, int layoutId, @NonNull Riddle riddle, @Nullable Coin coin) {
      Severity: Minor
      Found in app/src/main/java/sdp/moneyrun/ui/map/MapActivity.java - About 35 mins to fix

        Method placeRandomCoins has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public void placeRandomCoins(int number, double maxRadius, double minRadius) {
        if (number < 0 || maxRadius <= 0 || minRadius <= 0)
            throw new IllegalArgumentException("Number of coins to place is less than 0, number of coin is  " + number);
        if (minRadius >= maxRadius)
            throw new IllegalArgumentException("Min radius cannot be bigger or equal than max Radius ");
        Severity: Minor
        Found in app/src/main/java/sdp/moneyrun/ui/map/MapActivity.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if (ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED && ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
            return;
        }
        Severity: Minor
        Found in app/src/main/java/sdp/moneyrun/ui/map/MapActivity.java and 1 other location - About 35 mins to fix
        app/src/main/java/sdp/moneyrun/ui/menu/MenuActivity.java on lines 259..261

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status