Sign upLogin

Alvaro2112/Money_run

View on GitHub
Star
app/src/main/java/sdp/moneyrun/ui/map/OfflineMapDownloaderActivity.java

Summary

Maintainability
A
1 hr
Test Coverage
A
91%

OfflineMapDownloaderActivity has 24 methods (exceeds 20 allowed). Consider refactoring.
Wontfix

@SuppressWarnings("FieldCanBeLocal")
public class OfflineMapDownloaderActivity extends TrackedMap {

    // JSON encoding/decoding
    public static final String JSON_CHARSET = "UTF-8";
Severity: Minor
Found in app/src/main/java/sdp/moneyrun/ui/map/OfflineMapDownloaderActivity.java - About 2 hrs to fix

    Method deleteOlderMaps has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void deleteOlderMaps() {
        offlineManager.listOfflineRegions(new OfflineManager.ListOfflineRegionsCallback() {
            @Override
            public void onList(@NonNull OfflineRegion[] offlineRegions) {
    Severity: Minor
    Found in app/src/main/java/sdp/moneyrun/ui/map/OfflineMapDownloaderActivity.java - About 1 hr to fix

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

              exitButton.setOnClickListener(v -> {
            Intent mainIntent = new Intent(OfflineMapDownloaderActivity.this, MenuActivity.class);
            mainIntent.putExtra("user", user);
            startActivity(mainIntent);
            finish();
      Severity: Major
      Found in app/src/main/java/sdp/moneyrun/ui/map/OfflineMapDownloaderActivity.java and 3 other locations - About 35 mins to fix
      app/src/main/java/sdp/moneyrun/ui/menu/friendlist/FriendListActivity.java on lines 52..57
      app/src/main/java/sdp/moneyrun/ui/menu/leaderboards/LeaderboardActivity.java on lines 142..147
      app/src/main/java/sdp/moneyrun/ui/menu/leaderboards/MainLeaderboardActivity.java on lines 54..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 44.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status