Sign upLogin

Alvaro2112/Money_run

View on GitHub
Star
app/src/main/java/sdp/moneyrun/ui/menu/leaderboards/MainLeaderboardActivity.java

Summary

Maintainability
A
1 hr
Test Coverage
A
96%

Identical blocks of code found in 4 locations. Consider refactoring.
Open

        backToMenu.setOnClickListener(v -> {
            Intent menuIntent = new Intent(MainLeaderboardActivity.this, MenuActivity.class);
            menuIntent.putExtra("user", user);
            startActivity(menuIntent);
            finish();
Severity: Major
Found in app/src/main/java/sdp/moneyrun/ui/menu/leaderboards/MainLeaderboardActivity.java and 3 other locations - About 35 mins to fix
app/src/main/java/sdp/moneyrun/ui/map/OfflineMapDownloaderActivity.java on lines 74..79
app/src/main/java/sdp/moneyrun/ui/menu/friendlist/FriendListActivity.java on lines 52..57
app/src/main/java/sdp/moneyrun/ui/menu/leaderboards/LeaderboardActivity.java on lines 142..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @RequiresApi(api = Build.VERSION_CODES.N)
    public void addUser(@Nullable User user) {
        // can't just add a user directly to an adapter, we need to put it in a list first.
        if (user == null) {
            throw new IllegalArgumentException("user should not be null.");
Severity: Minor
Found in app/src/main/java/sdp/moneyrun/ui/menu/leaderboards/MainLeaderboardActivity.java and 1 other location - About 30 mins to fix
app/src/main/java/sdp/moneyrun/ui/menu/leaderboards/LeaderboardActivity.java on lines 84..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status