Showing 37 of 40 total issues
File MapActivity.java
has 571 lines of code (exceeds 250 allowed). Consider refactoring. Open
package sdp.moneyrun.ui.map;
import android.Manifest;
import android.content.pm.PackageManager;
import android.graphics.Color;
MapActivity
has 53 methods (exceeds 20 allowed). Consider refactoring. Open
@SuppressWarnings({"CanBeFinal", "FieldCanBeLocal"})
public class MapActivity extends TrackedMap implements OnMapReadyCallback {
public static final int THRESHOLD_DISTANCE = 5;
public static final float DISTANCE_CHANGE_BEFORE_UPDATE = (float) 2;
private static final long MINIMUM_TIME_BEFORE_UPDATE = 2000;
File Game.java
has 434 lines of code (exceeds 250 allowed). Consider refactoring. Open
package sdp.moneyrun.game;
import android.app.Activity;
import android.content.Intent;
Game
has 40 methods (exceeds 20 allowed). Consider refactoring. Open
@SuppressWarnings("FieldCanBeLocal")
public class Game {
private final String DATABASE_GAME = "games";
private final String DATABASE_PLAYER = "players";
GameDbData
has 30 methods (exceeds 20 allowed). Consider refactoring. Open
public final class GameDbData {
boolean isVisible;
boolean isDeleted;
boolean started;
boolean ended;
User
has 26 methods (exceeds 20 allowed). Consider refactoring. Open
public class User implements Serializable {
@Nullable
private String userId;
@Nullable
GameLobbyActivity
has 23 methods (exceeds 20 allowed). Consider refactoring. Open
@SuppressWarnings("FieldCanBeLocal")
public class GameLobbyActivity extends AppCompatActivity {
private final String TAG = GameLobbyActivity.class.getSimpleName();
private final String DB_IS_DELETED = "isDeleted";
private final String DB_PLAYERS = "players";
File GameDbData.java
has 261 lines of code (exceeds 250 allowed). Consider refactoring. Open
package sdp.moneyrun.database.game;
import android.location.Location;
import androidx.annotation.NonNull;
MenuActivity
has 21 methods (exceeds 20 allowed). Consider refactoring. Open
@SuppressWarnings({"CanBeFinal", "FieldCanBeLocal"})
public class MenuActivity extends AppCompatActivity implements NavigationView.OnNavigationItemSelectedListener {
//In meters
public static final float DISTANCE_CHANGE_BEFORE_UPDATE = (float) 100.0;
private static final long MINIMUM_TIME_BEFORE_UPDATE = 10000;
Method onDestroy
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
@Override
protected void onDestroy() {
super.onDestroy();
DatabaseProxy.removeOfflineListener();
if (playerListListener != null)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File GameLobbyActivity.java
has 252 lines of code (exceeds 250 allowed). Consider refactoring. Open
package sdp.moneyrun.ui.game;
import android.content.Intent;
import android.os.Bundle;
import android.util.Log;
Method getGameFromTaskSnapshot
has 47 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Nullable
public Game getGameFromTaskSnapshot(@Nullable Task<DataSnapshot> task) {
if (task == null)
throw new IllegalArgumentException("task should not be null.");
Method getGameFromTaskSnapshot
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
@Nullable
public Game getGameFromTaskSnapshot(@Nullable Task<DataSnapshot> task) {
if (task == null)
throw new IllegalArgumentException("task should not be null.");
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getRawForecast
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Nullable
private String getRawForecast(@NonNull LocationRepresentation location) throws IOException {
String queryUrl = API_ENDPOINT +
"?lat=" + location.getLatitude() +
"&lon=" + location.getLongitude() +
Method equals
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
@Override
public boolean equals(@Nullable Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
Riddle riddle = (Riddle) o;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method onNavigationItemSelected
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
@SuppressLint("NonConstantResourceId")
@Override
public boolean onNavigationItemSelected(@NonNull MenuItem item) {
MediaPlayer.create(this, R.raw.button_press).start();
switch (item.getItemId()) {
Method deleteOlderMaps
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
private void deleteOlderMaps() {
offlineManager.listOfflineRegions(new OfflineManager.ListOfflineRegionsCallback() {
@Override
public void onList(@NonNull OfflineRegion[] offlineRegions) {
Method listenToStarted
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
private void listenToStarted() {
if (!game.getHost().equals(player)) {
isStartedListener = new ValueEventListener() {
@Override
public void onDataChange(@NonNull DataSnapshot snapshot) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Identical blocks of code found in 2 locations. Consider refactoring. Open
@Nullable
public View getView(int position, @Nullable View view, ViewGroup parent) {
if (view == null)
view = LayoutInflater.from(getContext()).inflate(R.layout.leaderboard_item_layout, parent, false);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 60.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method postNewGame
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public void postNewGame(String name, int maxPlayerCount, int numCoins, double gameRadius, double gameDuration, @NonNull LocationRepresentation location) {