AndyObtiva/glimmer

View on GitHub

Showing 7 of 32 total issues

Class ModelBinding has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

    class ModelBinding
      include Observable
      include Observer
      
      ARRAY_INDEXED_PROPERTY_ARGUMENT_REGEX = /\d+/
Severity: Minor
Found in lib/glimmer/data_binding/model_binding.rb - About 3 hrs to fix

    Method method_missing has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def method_missing(method_symbol, *args, &block)
        # This if statement speeds up Glimmer in girb or whenever directly including on main object
        is_excluded = Config.excluded_keyword_checkers.any? do |checker|
          instance_exec(method_symbol, *args, &checker)
        end
    Severity: Minor
    Found in lib/glimmer.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_nested_observers has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def add_nested_observers(observer)
            nested_property_observers = nested_property_observers_for(observer)
            Concurrent::Array.new(nested_models.zip(nested_property_names)).each_with_index do |zip, i|
              model, property_name = zip
              nested_property_observer = nested_property_observers[property_name]
    Severity: Minor
    Found in lib/glimmer/data_binding/model_binding.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method observe has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def observe(observable, *args)
            options = args.last.is_a?(Hash) ? args.last : {}
            return if observable.nil?
            return if options[:ignore_frozen] && observable.frozen?
            unless observable.is_a?(Observable)
    Severity: Minor
    Found in lib/glimmer/data_binding/observer.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def call(value, *extra_args)
            return if model.nil?
            converted_value = value
            invoke_property_writer(model, model.is_a?(Hash) && !property_indexed?(property_name) ? property_name : "#{property_name}=", converted_value) unless converted_value == evaluate_property || property_name.nil?
          end
    Severity: Minor
    Found in lib/glimmer/data_binding/model_binding.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method can_interpret? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def can_interpret?(parent, keyword, *args, &block)
            result = false
            result ||= keyword.downcase == keyword if self.class.downcased?
            result ||= keyword.upcase == keyword if self.class.upcased?
            result ||= keyword.capitalize == keyword if self.class.capitalized?
    Severity: Minor
    Found in lib/glimmer/dsl/static_expression.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_observer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def add_observer(observer, *args)
            options = args.last.is_a?(Hash) ? args.pop : {}
            element_properties = args.flatten.compact.uniq
            return observer if has_observer?(observer) && has_observer_element_properties?(observer, element_properties)
            property_observer_list[observer] = options
    Severity: Minor
    Found in lib/glimmer/data_binding/observable_array.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language