Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
class/Admin.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '46', column '20').
Open

        return new \PHPWS_DB('intern_admin');
Severity: Minor
Found in class/Admin.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method allowed uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        }else{
            return false;
        }
Severity: Minor
Found in class/Admin.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Current_User' in method 'currentAllowed'.
Open

        return self::allowed(\Current_User::getUsername(), $dept);
Severity: Minor
Found in class/Admin.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\PHPWS_Core' in method 'currentAllowed'.
Open

        \PHPWS_Core::initModClass('users', 'Current_User.php');
Severity: Minor
Found in class/Admin.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Saw an @override annotation for method \Intern\Admin::getDb, but could not find an overridden method and it is not a magic method
Open

    public static function getDb()
Severity: Info
Found in class/Admin.php by phan

Call to method addWhere from undeclared class \Intern\PHPWS_DB
Open

        $db->addWhere('username', $username);
Severity: Critical
Found in class/Admin.php by phan

Call to method addColumn from undeclared class \Intern\PHPWS_DB
Open

        $db->addColumn('id', $count=true);
Severity: Critical
Found in class/Admin.php by phan

Call to method __construct from undeclared class \Intern\PHPWS_DB
Open

        $db = new PHPWS_DB('intern_admin');
Severity: Critical
Found in class/Admin.php by phan

Call to method select from undeclared class \Intern\PHPWS_DB
Open

        $count = $db->select();
Severity: Critical
Found in class/Admin.php by phan

Call to method initModClass from undeclared class \PHPWS_Core
Open

        \PHPWS_Core::initModClass('users', 'Current_User.php');
Severity: Critical
Found in class/Admin.php by phan

Call to method getUsername from undeclared class \Current_User
Open

        return self::allowed(\Current_User::getUsername(), $dept);
Severity: Critical
Found in class/Admin.php by phan

Call to method __construct from undeclared class \PHPWS_DB
Open

        return new \PHPWS_DB('intern_admin');
Severity: Critical
Found in class/Admin.php by phan

Possibly zero references to use statement for classlike/namespace NotifyUI (\Intern\UI\NotifyUI)
Open

use \Intern\UI\NotifyUI;
Severity: Minor
Found in class/Admin.php by phan

Call to method addWhere from undeclared class \Intern\PHPWS_DB
Open

        $db->addWhere('department_id', $dept);
Severity: Critical
Found in class/Admin.php by phan

The property $department_id is not named in camelCase.
Open

class Admin extends Model
{
    public $username;
    public $department_id;
Severity: Minor
Found in class/Admin.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Avoid variables with short names like $db. Configured minimum length is 3.
Open

        $db = new PHPWS_DB('intern_admin');
Severity: Minor
Found in class/Admin.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $department_name is not named in camelCase.
Open

class Admin extends Model
{
    public $username;
    public $department_id;
Severity: Minor
Found in class/Admin.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

There are no issues that match your filters.

Category
Status