Sign upLogin

AppStateESS/InternshipInventory

View on GitHub
Star
class/DataProvider/Major/TestMajorsProvider.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '56', column '22').
Open

        $major = new \stdClass();
Severity: Minor
Found in class/DataProvider/Major/TestMajorsProvider.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid unused parameters such as '$term'.
Open

    public function getMajors($term): AcademicMajorList
Severity: Minor
Found in class/DataProvider/Major/TestMajorsProvider.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Call with 1 arg(s) to \Intern\AcademicMajorList::__construct() which only takes 0 arg(s) defined at /code/class/AcademicMajorList.php:33
Open

        return new AcademicMajorList($majors);
Severity: Info
Found in class/DataProvider/Major/TestMajorsProvider.php by phan

Avoid variables with short names like $m1. Configured minimum length is 3.
Open

        $m1 = $this->createMajor('219A', 'Computer Science', 'G');
Severity: Minor
Found in class/DataProvider/Major/TestMajorsProvider.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $m3. Configured minimum length is 3.
Open

        $m3 = $this->createMajor('301A', 'Accounting', 'G');
Severity: Minor
Found in class/DataProvider/Major/TestMajorsProvider.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $m5. Configured minimum length is 3.
Open

        $m5 = $this->createMajor('301A', 'Accounting', 'U');
Severity: Minor
Found in class/DataProvider/Major/TestMajorsProvider.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $m6. Configured minimum length is 3.
Open

        $m6 = $this->createMajor('303A', 'Banking', 'U');
Severity: Minor
Found in class/DataProvider/Major/TestMajorsProvider.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $m2. Configured minimum length is 3.
Open

        $m2 = $this->createMajor('355*', 'Management', 'G');
Severity: Minor
Found in class/DataProvider/Major/TestMajorsProvider.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $m4. Configured minimum length is 3.
Open

        $m4 = $this->createMajor('301A', 'Accounting', 'U');
Severity: Minor
Found in class/DataProvider/Major/TestMajorsProvider.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status