AsgardCms/User

View on GitHub

Showing 10 of 12 total issues

Method run has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        Model::unguard();

        $groups = Sentinel::getRoleRepository();
Severity: Major
Found in Database/Seeders/SentinelGroupSeedTableSeeder.php - About 3 hrs to fix

    Method run has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function run()
        {
            $this->role->create(array(
                'name'        => 'Admin',
                'permissions' => [
    Severity: Major
    Found in Database/Seeders/UsherTableSeeder.php - About 2 hrs to fix

      Method run has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function run()
          {
              Model::unguard();
      
              // Create an Admin group
      Severity: Major
      Found in Database/Seeders/SentryGroupSeedTableSeeder.php - About 2 hrs to fix

        Function updateAndSyncRoles has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function updateAndSyncRoles($userId, $data, $roles)
            {
                $user = Sentry::findUserById($userId);
        
                $this->checkForNewPassword($data);
        Severity: Minor
        Found in Repositories/Sentry/SentryUserRepository.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method extendWith has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function extendWith(Menu $menu)
            {
                $menu->group(trans('workshop::workshop.title'), function (Group $group) {
        
                    $group->item(trans('user::users.title.users'), function (Item $item) {
        Severity: Minor
        Found in Sidebar/SidebarExtender.php - About 1 hr to fix

          Function login has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function login(array $credentials, $remember = false)
              {
                  try {
                      Sentry::authenticate($credentials, $remember);
          
          
          Severity: Minor
          Found in Repositories/Sentry/SentryAuthentication.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return 'User is not activated.';
          Severity: Major
          Found in Repositories/Sentry/SentryAuthentication.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return 'User was not found.';
            Severity: Major
            Found in Repositories/Sentry/SentryAuthentication.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return 'User is suspended.';
              Severity: Major
              Found in Repositories/Sentry/SentryAuthentication.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return 'User is banned.';
                Severity: Major
                Found in Repositories/Sentry/SentryAuthentication.php - About 30 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language