Astrotomic/laravel-linfo

View on GitHub

Showing 12 of 12 total issues

Model has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class Model implements Arrayable, Jsonable
{
    /**
     * @var array
     */
Severity: Minor
Found in src/Linfo/Models/Model.php - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function setCreatedAtProcessed()
        {
            if (! empty(array_get($this->attributes, 'timestamp'))) {
                return $this->asDateTime(array_get($this->attributes, 'timestamp'))->setTimezone('UTC');
            }
    Severity: Major
    Found in src/Linfo/Traits/LinfoProcessedTrait.php and 1 other location - About 1 hr to fix
    src/Linfo/Traits/LinfoProcessedTrait.php on lines 12..17

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function setBootedAtProcessed()
        {
            if (! empty(array_get($this->attributes, 'uptime.bootedtimestamp'))) {
                return $this->asDateTime(array_get($this->attributes, 'uptime.bootedtimestamp'))->setTimezone('UTC');
            }
    Severity: Major
    Found in src/Linfo/Traits/LinfoProcessedTrait.php and 1 other location - About 1 hr to fix
    src/Linfo/Traits/LinfoProcessedTrait.php on lines 19..24

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this method.
    Open

                    return json_decode($value, true);
    Severity: Major
    Found in src/Linfo/Models/Model.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return new Carbon($value);
      Severity: Major
      Found in src/Linfo/Models/Model.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $value;
        Severity: Major
        Found in src/Linfo/Models/Model.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return (bool) $value;
          Severity: Major
          Found in src/Linfo/Models/Model.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return json_decode($value);
            Severity: Major
            Found in src/Linfo/Models/Model.php - About 30 mins to fix

              The method setUptimeAttribute uses an else expression. Else is never necessary and you can simplify the code to work without else.
              Open

                      } else {
                          $valArray = explode(';', $value);
                          $uptime = trim($valArray[0]);
                          $bootedtime = trim(explode(' ', trim($valArray[1]))[1]);
                          $this->attributes['uptime']['text'] = $uptime;
              Severity: Minor
              Found in src/Linfo/Models/Linfo.php by phpmd

              Since: PHPMD 1.4.0

              An if expression with an else branch is never necessary. You can rewrite the conditions in a way that the else is not necessary and the code becomes simpler to read. To achieve this use early return statements. To achieve this you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example:

              class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

              Source: http://phpmd.org/rules/cleancode.txt

              setWebServerProcessed accesses the super-global variable $_SERVER.
              Open

                  public function setWebServerProcessed()
                  {
                      return ! empty($_SERVER['SERVER_SOFTWARE']) ? $_SERVER['SERVER_SOFTWARE'] : '';
                  }

              Since: PHPMD 0.2

              Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

              Example:

              class Foo {
                    public function bar() {
                        $name = $_POST['foo'];
                    }
                }

              Source: http://phpmd.org/rules/controversial.txt

              The method castAttribute() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
              Open

                  protected function castAttribute($key, $value)
                  {
                      if (is_null($value)) {
                          return $value;
                      }
              Severity: Minor
              Found in src/Linfo/Models/Model.php by phpmd

              Since: PHPMD 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example:

              // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

              Source: http://phpmd.org/rules/codesize.txt

              setWebServerProcessed accesses the super-global variable $_SERVER.
              Open

                  public function setWebServerProcessed()
                  {
                      return ! empty($_SERVER['SERVER_SOFTWARE']) ? $_SERVER['SERVER_SOFTWARE'] : '';
                  }

              Since: PHPMD 0.2

              Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

              Example:

              class Foo {
                    public function bar() {
                        $name = $_POST['foo'];
                    }
                }

              Source: http://phpmd.org/rules/controversial.txt

              Severity
              Category
              Status
              Source
              Language