Authmaker/authmaker-verify-express

View on GitHub

Showing 5 of 5 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    return authmakerVerify.mongoRateLimited(accessToken, tag, defaultScope)

      .then((oauthSession) => {
        req.oauthSession = oauthSession;

Severity: Major
Found in index.js and 1 other location - About 2 hrs to fix
index.js on lines 81..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    return Q.fcall(() => {
      if (!req.headers.authorization) {
        throw new Error('Not Authorized: No Access token provided');
      }

Severity: Major
Found in index.js and 1 other location - About 2 hrs to fix
index.js on lines 40..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function generateVerify has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function generateVerify(tag, options) {
  return function (req, res, next) {
    // verify the access-token
    return Q.fcall(() => {
      if (!req.headers.authorization) {
Severity: Minor
Found in index.js - About 1 hr to fix

    Function generateRateLimit has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function generateRateLimit(tag, defaultScope) {
      return function rateLimit(req, res, next) {
        if (!req.headers.authorization) {
          return res.status(401).send('No Access token provided');
        }
    Severity: Minor
    Found in index.js - About 1 hr to fix

      Function rateLimit has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        return function rateLimit(req, res, next) {
          if (!req.headers.authorization) {
            return res.status(401).send('No Access token provided');
          }
      
      
      Severity: Minor
      Found in index.js - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language