AyuntamientoMadrid/participacion

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "#cleanup_investments_tags!" do
    it "does not delete other machine learning generated data" do
      create(:ml_summary_comment, commentable: create(:proposal))
      create(:ml_summary_comment, commentable: create(:budget_investment))

• Read up
  Read up

File menu_component.rb has 494 lines of code (exceeds 250 allowed). Consider refactoring.

Open

class Admin::MenuComponent < ApplicationComponent
  include LinkListHelper
  use_helpers :can?

  def links

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context "reorder" do
      it "is able to reorder by hot_score after searching" do
        lowest_score  = create(:proposal,  title: "stop corruption", cached_votes_up: 1)
        highest_score = create(:proposal,  title: "stop corruption", cached_votes_up: 2)
        average_score = create(:proposal,  title: "stop corruption", cached_votes_up: 3)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context "reorder" do
      it "is able to reorder by hot_score after searching" do
        lowest_score  = create(:debate,  title: "stop corruption", cached_votes_up: 1)
        highest_score = create(:debate,  title: "stop corruption", cached_votes_up: 2)
        average_score = create(:debate,  title: "stop corruption", cached_votes_up: 3)

• Read up
  Read up

File machine_learning_spec.rb has 481 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe MachineLearning do
  def full_sanitizer(string)
    ActionView::Base.full_sanitizer.sanitize(string)

File graphql_spec.rb has 468 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

def execute(query_string, context = {}, variables = {})
  ConsulSchema.execute(query_string, context: context, variables: variables)
end

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "save latitude" do
    it "Doesn't allow latitude < -90" do
      heading = create(:budget_heading, group: group, name: "Latitude is < -90")

      heading.latitude = "-90.127491"

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "save longitude" do
    it "Doesn't allow longitude < -180" do
      heading = create(:budget_heading, group: group, name: "Longitude is < -180")

      heading.longitude = "-180.127491"

• Read up
  Read up

Class Investment has 51 methods (exceeds 20 allowed). Consider refactoring.

Open

  class Investment < ApplicationRecord
    SORTING_OPTIONS = { id: "id", supports: "cached_votes_up" }.freeze

    include Measurable
    include Sanitizable

File poll_spec.rb has 460 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe Poll do
  let(:poll) { build(:poll, :future) }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  context "Search" do
    let(:user)      { create(:user, username: "Taylor Swift", email: "taylor@swift.com") }
    let(:user2)     { create(:user, username: "Stephanie Corneliussen", email: "steph@mrrobot.com") }
    let!(:manager1) { create(:manager, user: user) }
    let!(:manager2) { create(:manager, user: user2) }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  context "Search" do
    let(:user)        { create(:user, username: "Elizabeth Bathory", email: "elizabeth@bathory.com") }
    let(:user2)       { create(:user, username: "Ada Lovelace", email: "ada@lovelace.com") }
    let!(:moderator1) { create(:moderator, user: user) }
    let!(:moderator2) { create(:moderator, user: user2) }

• Read up
  Read up

File budget_spec.rb has 434 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe Budget do
  let(:budget) { create(:budget) }

File polls_spec.rb has 431 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe "Admin polls", :admin do
  scenario "Index empty" do
    visit admin_root_path

Class MachineLearning has 45 methods (exceeds 20 allowed). Consider refactoring.

Open

class MachineLearning
  attr_reader :user, :script, :previous_modified_date
  attr_accessor :job

  SCRIPTS_FOLDER = Rails.root.join("public", "machine_learning", "scripts").freeze

File budget_investments_spec.rb has 418 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe "Budget Investments" do
  let(:manager) { create(:manager) }
  let(:budget)  { create(:budget, :selecting, name: "2033", slug: "budget_slug") }

File machine_learning.rb has 414 lines of code (exceeds 250 allowed). Consider refactoring.

Open

class MachineLearning
  attr_reader :user, :script, :previous_modified_date
  attr_accessor :job

  SCRIPTS_FOLDER = Rails.root.join("public", "machine_learning", "scripts").freeze

File dashboard_spec.rb has 413 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe "Proposal's dashboard" do
  let(:proposal) { create(:proposal, :draft) }
  before { login_as(proposal.author) }

File emails_spec.rb has 410 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe "Emails" do
  before do
    reset_mailer

File budget_investments_spec.rb has 408 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe "Valuation budget investments" do
  let(:budget) { create(:budget, :valuating) }
  let(:valuator) do