BKWLD/laravel-pug

View on GitHub
src/ExceptionHandlerTrait.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method filterErrorResponse has 98 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function filterErrorResponse(\Exception $exception, $request, $response)
    {
        if ($this->container->has('laravel-pug.pug')) {
            /** @var Pug $pug */
            $pug = $this->container->get('laravel-pug.pug');
Severity: Major
Found in src/ExceptionHandlerTrait.php - About 3 hrs to fix

    Function filterErrorResponse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function filterErrorResponse(\Exception $exception, $request, $response)
        {
            if ($this->container->has('laravel-pug.pug')) {
                /** @var Pug $pug */
                $pug = $this->container->get('laravel-pug.pug');
    Severity: Minor
    Found in src/ExceptionHandlerTrait.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return $response;
    Severity: Major
    Found in src/ExceptionHandlerTrait.php - About 30 mins to fix

      The method filterErrorResponse() has 116 lines of code. Current threshold is set to 100. Avoid really long methods.
      Open

          public function filterErrorResponse(\Exception $exception, $request, $response)
          {
              if ($this->container->has('laravel-pug.pug')) {
                  /** @var Pug $pug */
                  $pug = $this->container->get('laravel-pug.pug');
      Severity: Minor
      Found in src/ExceptionHandlerTrait.php by phpmd

      The method filterErrorResponse() has an NPath complexity of 200. The configured NPath complexity threshold is 200.
      Open

          public function filterErrorResponse(\Exception $exception, $request, $response)
          {
              if ($this->container->has('laravel-pug.pug')) {
                  /** @var Pug $pug */
                  $pug = $this->container->get('laravel-pug.pug');
      Severity: Minor
      Found in src/ExceptionHandlerTrait.php by phpmd

      Since: PHPMD 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example:

      class Foo {
            function bar() {
                // lots of complicated code
            }
        }

      Source: http://phpmd.org/rules/codesize.txt

      The method filterErrorResponse() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
      Open

          public function filterErrorResponse(\Exception $exception, $request, $response)
          {
              if ($this->container->has('laravel-pug.pug')) {
                  /** @var Pug $pug */
                  $pug = $this->container->get('laravel-pug.pug');
      Severity: Minor
      Found in src/ExceptionHandlerTrait.php by phpmd

      Since: PHPMD 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example:

      // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

      Source: http://phpmd.org/rules/codesize.txt

      There are no issues that match your filters.

      Category
      Status