Method filterErrorResponse
has 98 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function filterErrorResponse(\Exception $exception, $request, $response)
{
if ($this->container->has('laravel-pug.pug')) {
/** @var Pug $pug */
$pug = $this->container->get('laravel-pug.pug');
Function filterErrorResponse
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function filterErrorResponse(\Exception $exception, $request, $response)
{
if ($this->container->has('laravel-pug.pug')) {
/** @var Pug $pug */
$pug = $this->container->get('laravel-pug.pug');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return $response;
The method filterErrorResponse() has 116 lines of code. Current threshold is set to 100. Avoid really long methods. Open
public function filterErrorResponse(\Exception $exception, $request, $response)
{
if ($this->container->has('laravel-pug.pug')) {
/** @var Pug $pug */
$pug = $this->container->get('laravel-pug.pug');
- Exclude checks
The method filterErrorResponse() has an NPath complexity of 200. The configured NPath complexity threshold is 200. Open
public function filterErrorResponse(\Exception $exception, $request, $response)
{
if ($this->container->has('laravel-pug.pug')) {
/** @var Pug $pug */
$pug = $this->container->get('laravel-pug.pug');
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method filterErrorResponse() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open
public function filterErrorResponse(\Exception $exception, $request, $response)
{
if ($this->container->has('laravel-pug.pug')) {
/** @var Pug $pug */
$pug = $this->container->get('laravel-pug.pug');
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Remove error control operator '@' on line 84. Open
public function filterErrorResponse(\Exception $exception, $request, $response)
{
if ($this->container->has('laravel-pug.pug')) {
/** @var Pug $pug */
$pug = $this->container->get('laravel-pug.pug');
- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}