Barzahlen/gcra-ruby

View on GitHub

Showing 4 of 4 total issues

Method limit has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def limit(key, quantity)
      key = key.to_s unless key.is_a?(String)
      i = 0

      while i < MAX_ATTEMPTS
Severity: Minor
Found in lib/gcra/rate_limiter.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method limit has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def limit(key, quantity)
      key = key.to_s unless key.is_a?(String)
      i = 0

      while i < MAX_ATTEMPTS
Severity: Minor
Found in lib/gcra/rate_limiter.rb - About 1 hr to fix

    Method compare_and_set_with_ttl has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def compare_and_set_with_ttl(key, old_value, new_value, ttl_nano)
          full_key = @key_prefix + key
          retried = false
          begin
            ttl_milli = calculate_ttl_milli(ttl_nano)
    Severity: Minor
    Found in lib/gcra/redis_store.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method mark_overflowed has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def mark_overflowed(key)
          key = key.to_s unless key.is_a?(String)
          i = 0
          while i < MAX_ATTEMPTS
            tat_from_store, now = @store.get_with_time(key)
    Severity: Minor
    Found in lib/gcra/rate_limiter.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language