Sign upLogin

BlindlyTeam/Blindly

View on GitHub
Star

Showing 33 of 107 total issues

Method startProfileBirthday has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    /**
     * Gets the name of the user as input, checks it to be alphabetical and within
     * character limits, if so passes it to builder and then fires Birthday Activity,
     * if not outputs error message
     *
Severity: Minor
Found in app/src/main/java/ch/epfl/sdp/blindly/profile_setup/ProfileName.kt - About 1 hr to fix

    Method onCreate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_user_map)
        // Obtain the SupportMapFragment and get notified when the map is ready to be used.
        val mapFragment = supportFragmentManager
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sdp/blindly/main_screen/map/UserMapActivity.kt - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          override fun onBackPressed() {
        if (sexualOrientationsAreCorrect()) {
            viewModel.updateField(
                SEXUAL_ORIENTATIONS,
                ProfileOrientation.getChipTextsFromIds(chipGroup)
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sdp/blindly/main_screen/profile/edit/EditSexualOrientations.kt and 1 other location - About 45 mins to fix
      app/src/main/java/ch/epfl/sdp/blindly/main_screen/profile/edit/EditPassions.kt on lines 54..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          override fun onBackPressed() {
        if (passionsAreCorrect()) {
            viewModel.updateField(PASSIONS, ProfileOrientation.getChipTextsFromIds(chipGroup))
            super.onBackPressed()
        }
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sdp/blindly/main_screen/profile/edit/EditPassions.kt and 1 other location - About 45 mins to fix
      app/src/main/java/ch/epfl/sdp/blindly/main_screen/profile/edit/EditSexualOrientations.kt on lines 54..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (ageRange != null) {
            return listOf(ageRange[0].toInt(), ageRange[1].toInt())
        }
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt and 1 other location - About 40 mins to fix
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 98..100

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (loc != null) {
            return listOf(loc[0].toDouble(), loc[1].toDouble())
        }
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt and 1 other location - About 40 mins to fix
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 205..207

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          fun startUsernameEdit(view: View) {
        val intent = Intent(this, EditUsername::class.java)
        startActivity(intent)
    }
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sdp/blindly/main_screen/profile/edit/EditProfile.kt and 1 other location - About 35 mins to fix
      app/src/main/java/ch/epfl/sdp/blindly/profile_setup/ProfileHouseRules.kt on lines 20..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  TemperatureUnit.IMPERIAL -> String.format(
                getString(R.string.fahrenheit_temperature),
                temperature.toInt()
            );
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sdp/blindly/weather/WeatherActivity.kt and 1 other location - About 35 mins to fix
      app/src/main/java/ch/epfl/sdp/blindly/weather/WeatherActivity.kt on lines 81..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  TemperatureUnit.METRIC -> String.format(
                getString(R.string.celsius_temperature),
                temperature.toInt()
            );
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sdp/blindly/weather/WeatherActivity.kt and 1 other location - About 35 mins to fix
      app/src/main/java/ch/epfl/sdp/blindly/weather/WeatherActivity.kt on lines 77..80

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          /**
     * Get the likes from a given uid
     *
     * @param id the uid to find the user
     * @return the user's likes
      Severity: Major
      Found in app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt and 3 other locations - About 30 mins to fix
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 122..129
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 140..147
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 158..165

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          /**
     * Get the passions from a given uid
     *
     * @param id the uid to find the user
     * @return the user's passions
      Severity: Major
      Found in app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt and 3 other locations - About 30 mins to fix
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 122..129
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 158..165
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 167..174

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          /**
     * Get the sexualOrientation from a given uid
     *
     * @param id the uid to find the user
     * @return the user's sexualOrientation
      Severity: Major
      Found in app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt and 3 other locations - About 30 mins to fix
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 140..147
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 158..165
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 167..174

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          /**
     * Get the matches from a given uid
     *
     * @param id the uid to find the user
     * @return the user's matches
      Severity: Major
      Found in app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt and 3 other locations - About 30 mins to fix
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 122..129
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 140..147
      app/src/main/java/ch/epfl/sdp/blindly/database/localDB/UserDAO.kt on lines 167..174

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language