Sign upLogin

Bogdanp/h2p

View on GitHub
Star

Showing 3 of 3 total issues

Function generate_pdf has 15 arguments (exceeds 4 allowed). Consider refactoring.
Open

def generate_pdf(
Severity: Major
Found in h2p/h2p.py - About 1 hr to fix

    Function run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def run(self):
        # We have to initialize the Qt main loop in this thread
        # otherwise it'll just spin idly in the main thread.
        self.logger.debug("Booting up converter thread...")
        self.logger.debug("Initializing wkhtmltopdf main loop...")
    Severity: Minor
    Found in h2p/h2p.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _convert_args has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def _convert_args(args):
    converted_args = {}
    for name, value in args.items():
        if value is None:
            continue
    Severity: Minor
    Found in h2p/h2p.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language