BookStackApp/BookStack

View on GitHub
resources/js/wysiwyg/ui/framework/forms.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function getFieldByName has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    protected getFieldByName(name: string): EditorFormField|null {

        const search = (children: EditorUiElement[]): EditorFormField|null => {
            for (const child of children) {
                if (child instanceof EditorFormField && child.getName() === name) {
Severity: Minor
Found in resources/js/wysiwyg/ui/framework/forms.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildDOM has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected buildDOM(): HTMLElement {
        const controls: HTMLElement[] = [];
        const contents: HTMLElement[] = [];

        const selectTab = (tabIndex: number) => {
Severity: Minor
Found in resources/js/wysiwyg/ui/framework/forms.ts - About 1 hr to fix

    Function buildDOM has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected buildDOM(): HTMLElement {
            const controls: HTMLElement[] = [];
            const contents: HTMLElement[] = [];
    
            const selectTab = (tabIndex: number) => {
    Severity: Minor
    Found in resources/js/wysiwyg/ui/framework/forms.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status