BrownPaperBag/duffel-auth

View on GitHub
lib/models/User.js

Summary

Maintainability
C
1 day
Test Coverage

Function initialiseSchema has 191 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var initialiseSchema = function(database, additions) {

  /**
  * User model. Password hashing and flood control from:
  * {@link http://devsmash.com/blog/password-authentication-with-mongoose-and-bcrypt}
Severity: Major
Found in lib/models/User.js - About 7 hrs to fix

    Function initialiseSchema has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    var initialiseSchema = function(database, additions) {
    
      /**
      * User model. Password hashing and flood control from:
      * {@link http://devsmash.com/blog/password-authentication-with-mongoose-and-bcrypt}
    Severity: Minor
    Found in lib/models/User.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getAuthenticated has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      User.getAuthenticated = function(email, password, callback) {
        this.findOne({
          where: {
            email: email
          }
    Severity: Minor
    Found in lib/models/User.js - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status