Sign upLogin

CMSgov/dpc-app

View on GitHub
Star
dpc-api/src/main/java/gov/cms/dpc/api/resources/v1/GroupResource.java

Summary

Maintainability
A
55 mins
Test Coverage
B
88%

File GroupResource.java has 389 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

package gov.cms.dpc.api.resources.v1;

import ca.uhn.fhir.rest.api.MethodOutcome;
import ca.uhn.fhir.rest.client.api.IGenericClient;
import ca.uhn.fhir.rest.server.exceptions.ResourceNotFoundException;
Severity: Minor
Found in dpc-api/src/main/java/gov/cms/dpc/api/resources/v1/GroupResource.java - About 5 hrs to fix

    Method export has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Wontfix

        public Response export(@ApiParam(hidden = true) @Auth OrganizationPrincipal organizationPrincipal,
                           @ApiParam(value = "Provider ID", required = true)
                           @PathParam("rosterID") @NoHtml String rosterID,
                           @ApiParam(value = "List of FHIR resources to export", allowableValues = "ExplanationOfBenefits, Coverage, Patient")
                           @QueryParam("_type") @NoHtml String resourceTypes,
    Severity: Major
    Found in dpc-api/src/main/java/gov/cms/dpc/api/resources/v1/GroupResource.java - About 50 mins to fix

      Define a constant instead of duplicating this literal "Group" 6 times.
      Open

                      .withId(new IdType("Group", rosterID.toString()))
      Severity: Critical
      Found in dpc-api/src/main/java/gov/cms/dpc/api/resources/v1/GroupResource.java by sonar-java

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

      Compliant Solution

      private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          @Inject
    public GroupResource(IJobQueue queue, @Named("attribution") IGenericClient client, @APIV1 String baseURL, BlueButtonClient bfdClient, DPCAPIConfiguration config) {
        this.queue = queue;
        this.client = client;
        this.baseURL = baseURL;
      Severity: Major
      Found in dpc-api/src/main/java/gov/cms/dpc/api/resources/v1/GroupResource.java and 2 other locations - About 55 mins to fix
      dpc-attribution/src/main/java/gov/cms/dpc/attribution/resources/v1/V1AttributionResource.java on lines 17..28
      dpc-macaroons/src/main/java/gov/cms/dpc/macaroons/BakeryProvider.java on lines 27..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status