Sign upLogin

CMSgov/dpc-app

View on GitHub
Star
dpc-attribution/src/main/java/gov/cms/dpc/attribution/resources/v1/GroupResource.java

Summary

Maintainability
A
2 hrs
Test Coverage
B
83%

File GroupResource.java has 274 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

package gov.cms.dpc.attribution.resources.v1;

import com.codahale.metrics.annotation.ExceptionMetered;
import com.codahale.metrics.annotation.Timed;
import gov.cms.dpc.attribution.DPCAttributionConfiguration;
Severity: Minor
Found in dpc-attribution/src/main/java/gov/cms/dpc/attribution/resources/v1/GroupResource.java - About 2 hrs to fix

    Method addRosterMembers has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

        @POST
    @Path("/{rosterID}/$add")
    @FHIR
    @UnitOfWork
    @Override
    Severity: Minor
    Found in dpc-attribution/src/main/java/gov/cms/dpc/attribution/resources/v1/GroupResource.java - About 1 hr to fix

      Method replaceRoster has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @PUT
    @Path("/{rosterID}")
    @FHIR
    @UnitOfWork
    @Override
      Severity: Minor
      Found in dpc-attribution/src/main/java/gov/cms/dpc/attribution/resources/v1/GroupResource.java - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            GroupResource(FHIREntityConverter converter, ProviderDAO providerDAO, RosterDAO rosterDAO, PatientDAO patientDAO, RelationshipDAO relationshipDAO, DPCAttributionConfiguration config) {
        this.rosterDAO = rosterDAO;
        this.providerDAO = providerDAO;
        this.patientDAO = patientDAO;
        this.relationshipDAO = relationshipDAO;
        Severity: Minor
        Found in dpc-attribution/src/main/java/gov/cms/dpc/attribution/resources/v1/GroupResource.java and 1 other location - About 50 mins to fix
        dpc-aggregation/src/main/java/gov/cms/dpc/aggregation/engine/ResourceFetcher.java on lines 51..58

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status