Sign upLogin

CalebFenton/dex-oracle

View on GitHub
Star
lib/dex-oracle/smali_input.rb

Summary

Maintainability
A
1 hr
Test Coverage

Assignment Branch Condition size for prepare is too high. [24.04/15]
Open

  def prepare(input)
    if File.directory?(input)
      @temp_dir = false
      @temp_dex = true
      @dir = input
Severity: Minor
Found in lib/dex-oracle/smali_input.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method prepare has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def prepare(input)
    if File.directory?(input)
      @temp_dir = false
      @temp_dex = true
      @dir = input
Severity: Minor
Found in lib/dex-oracle/smali_input.rb - About 1 hr to fix

    %w-literals should be delimited by [ and ].
    Open

        out_dex = Tempfile.new(%w(oracle .dex)) if out_dex.nil?
    Severity: Minor
    Found in lib/dex-oracle/smali_input.rb by rubocop

    This cop enforces the consistent usage of %-literal delimiters.

    Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

    Example:

    # Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

    Useless assignment to variable - exit_code.
    Open

        exit_code = SmaliInput.exec("smali assemble -o #{out_dex.path} #{dir}")
    Severity: Minor
    Found in lib/dex-oracle/smali_input.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad

def some_method
  some_var = 1
  do_something
end

    Example:

    # good

def some_method
  some_var = 1
  do_something(some_var)
end

    %w-literals should be delimited by [ and ].
    Open

          @out_dex = Tempfile.new(%w(oracle .dex))
    Severity: Minor
    Found in lib/dex-oracle/smali_input.rb by rubocop

    This cop enforces the consistent usage of %-literal delimiters.

    Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

    Example:

    # Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

    Missing magic comment # frozen_string_literal: true.
    Open

    require 'zip'
    Severity: Minor
    Found in lib/dex-oracle/smali_input.rb by rubocop

    This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

    Example: EnforcedStyle: when_needed (default)

    # The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
  # ...
end

# good
# frozen_string_literal: true

module Foo
  # ...
end

    Example: EnforcedStyle: always

    # The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

    Example: EnforcedStyle: never

    # The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

    There are no issues that match your filters.

    Category
    Status