CartoDB/cartodb20

View on GitHub

Showing 2,455 of 5,951 total issues

Class DBService has 111 methods (exceeds 20 allowed). Consider refactoring.
Open

    class DBService
      include CartoDB::MiniSequel
      include Carto::Configuration
      include ::LoggerHelper
      extend CartoDB::SequelConnectionHelper
Severity: Major
Found in app/models/user/db_service.rb - About 2 days to fix

    File table.js has 834 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * models for cartodb admin
     */
    
    (function() {
    Severity: Major
    Found in lib/assets/javascripts/cartodb/models/table.js - About 2 days to fix

      Function exports has 387 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function (CodeMirror) {
        "use strict";
      
        var HINT_ELEMENT_CLASS        = "CodeMirror-hint";
        var ACTIVE_HINT_ELEMENT_CLASS = "CodeMirror-hint-active";

        File carto.js has 794 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        
        
        carto_quotables = [
          'text-face-name'
        ];
        Severity: Major
        Found in lib/assets/javascripts/cartodb/models/carto.js - About 1 day to fix

          Class Member has 96 methods (exceeds 20 allowed). Consider refactoring.
          Open

              class Member
                extend Forwardable
                include Virtus.model
                include CacheHelper
                include Carto::VisualizationDependencies
          Severity: Major
          Found in app/models/visualization/member.rb - About 1 day to fix

            File widgets.js has 733 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            
            /**
             *  Color form view
             *
             *  - It is used in 'Marker fill', 'Polygon fill',...
            Severity: Major
            Found in lib/assets/javascripts/cartodb/old_common/forms/widgets.js - About 1 day to fix

              Function exports has 337 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = function (grunt) {
                if (timer) timer.init(grunt);
              
                var environment = grunt.option('environment') || DEVELOPMENT;
                grunt.log.writeln('Environment: ' + environment);
              Severity: Major
              Found in Gruntfile.js - About 1 day to fix

                File visualization.rb has 698 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require 'active_record'
                require 'cartodb-common'
                require_relative '../visualization/stats'
                require_relative '../quota_checker'
                require_dependency 'carto/named_maps/api'
                Severity: Major
                Found in app/models/carto/visualization.rb - About 1 day to fix

                  File carto-table-metadata.js has 662 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  const _ = require('underscore');
                  const $ = require('jquery');
                  const Backbone = require('backbone');
                  const SQL = require('internal-carto.js').SQL;
                  const safeTableNameQuoting = require('dashboard/helpers/safe-table-name-quoting');

                    Class ImportJob has 79 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                        class ImportJob
                          include CartoDB::DataMover::Utils
                          include CartoDB::DataMover::LegacyFunctions
                          attr_reader :logger
                    
                    
                    Severity: Major
                    Found in services/user-mover/import_user.rb - About 1 day to fix

                      File layer_presenter.rb has 653 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      require_dependency 'carto/api/infowindow_migrator'
                      require_dependency 'carto/table_utils'
                      
                      module Carto
                        module Api
                      Severity: Major
                      Found in app/controllers/carto/api/layer_presenter.rb - About 1 day to fix

                        File import_user.rb has 653 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        require 'pg'
                        require 'redis'
                        require 'yaml'
                        require 'json'
                        require 'logger'
                        Severity: Major
                        Found in services/user-mover/import_user.rb - About 1 day to fix

                          File carto_wizard_forms.js has 652 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          
                          (function() {
                          
                          cdb.admin.forms = {};
                          
                          

                            File map.js has 650 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            
                            /*
                             * extend infowindow to serialize only the data we need
                             */
                            _.extend(cdb.geo.ui.InfowindowModel.prototype, {
                            Severity: Major
                            Found in lib/assets/javascripts/cartodb/models/map.js - About 1 day to fix

                              File user-actions.js has 645 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              var _ = require('underscore');
                              var $ = require('jquery');
                              var nodeIds = require('builder/value-objects/analysis-node-ids');
                              var MetricsTracker = require('builder/components/metrics/metrics-tracker');
                              var MetricsTypes = require('builder/components/metrics/metrics-types');
                              Severity: Major
                              Found in lib/assets/javascripts/builder/data/user-actions.js - About 1 day to fix

                                File carto-table-data.js has 642 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                const $ = require('jquery');
                                const Backbone = require('backbone');
                                const _ = require('underscore');
                                const TableDataCollection = require('dashboard/data/table/table-data-collection');
                                const RowModel = require('dashboard/data/table/row-model');
                                Severity: Major
                                Found in lib/assets/javascripts/dashboard/data/table/carto-table-data.js - About 1 day to fix

                                  File member.rb has 639 lines of code (exceeds 250 allowed). Consider refactoring.
                                  Open

                                  require 'forwardable'
                                  require 'virtus'
                                  require 'json'
                                  require 'cartodb-common'
                                  require_relative '../markdown_render'
                                  Severity: Major
                                  Found in app/models/visualization/member.rb - About 1 day to fix

                                    Class ApiKey has 76 methods (exceeds 20 allowed). Consider refactoring.
                                    Open

                                      class ApiKey < ActiveRecord::Base
                                    
                                        include Carto::AuthTokenGenerator
                                        include ::MessageBrokerHelper
                                    
                                    
                                    Severity: Major
                                    Found in app/models/carto/api_key.rb - About 1 day to fix

                                      File tabledata.js has 631 lines of code (exceeds 250 allowed). Consider refactoring.
                                      Open

                                      cdb.admin.CartoDBTableData = cdb.ui.common.TableData.extend({
                                        _ADDED_ROW_TEXT: 'Row added correctly',
                                        _ADDING_ROW_TEXT: 'Adding a new row',
                                        _GEOMETRY_UPDATED: 'Table geometry updated',
                                      
                                      
                                      Severity: Major
                                      Found in lib/assets/javascripts/cartodb/models/tabledata.js - About 1 day to fix

                                        Function exports has 271 lines of code (exceeds 25 allowed). Consider refactoring.
                                        Open

                                        module.exports = function (CodeMirror) {
                                          CodeMirror.defineMode('cartocss', function (config) {
                                            var indentUnit = config.indentUnit;
                                            var type;
                                        
                                        
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language