CastagnaIT/plugin.video.netflix

View on GitHub

Showing 91 of 337 total issues

Function _verify_session_cookies has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
Open

    def _verify_session_cookies(self):
        """Verify that the session cookies have not expired"""
        if not self.session.cookies:
            return False
        for cookie_name in LOGIN_COOKIES:
Severity: Minor
Found in resources/lib/services/nfsession/session/cookie.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function route_search_nav has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
Open

def route_search_nav(pathitems, perpetual_range_start, dir_update_listing, params):
    if 'query' in params:
        path = 'query'
    else:
        path = pathitems[2] if len(pathitems) > 2 else 'list'
Severity: Minor
Found in resources/lib/navigation/directory_search.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return base.replace('%PL%', '(X11; Linux x86_64)')
Severity: Major
Found in resources/lib/common/device_utils.py - About 30 mins to fix

    Function _mastertoken_checks has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

        def _mastertoken_checks(self):
            """Perform checks to the MasterToken and executes a new key handshake when necessary"""
            is_handshake_required = False
            if self.crypto.mastertoken:
                if self.crypto.is_current_mastertoken_expired():
    Severity: Minor
    Found in resources/lib/services/nfsession/msl/msl_requests.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function custom_viewmode has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    def custom_viewmode(content_type):
        """Decorator that sets a custom viewmode (skin viewtype) if currently in a listing of the plugin"""
        # pylint: disable=missing-docstring
        def decorate_viewmode(func):
            @wraps(func)
    Severity: Minor
    Found in resources/lib/navigation/directory_utils.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

        def __init__(self, path_response, context_name, context_id, req_sort_order_type):
            # LOG.debug('VideoListSorted data: {}', path_response)
            self.perpetual_range_selector = path_response.get('_perpetual_range_selector')
            self.data = path_response
            self.context_name = context_name
    Severity: Minor
    Found in resources/lib/utils/data_types.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _create_video_item has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    def _create_video_item(videoid_value, video, video_list, perpetual_range_start, common_data):  # pylint: disable=unused-argument
        videoid = common.VideoId.from_videolist_item(video)
        is_folder = videoid.mediatype == common.VideoId.SHOW
        is_playable = video['availability']['isPlayable']
        is_video_playable = not is_folder and is_playable
    Severity: Minor
    Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_system_platform has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    def get_system_platform():
        if not hasattr(get_system_platform, 'cached'):
            platform = "unknown"
            if xbmc.getCondVisibility('system.platform.linux') and not xbmc.getCondVisibility('system.platform.android'):
                platform = "linux"
    Severity: Minor
    Found in resources/lib/common/device_utils.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _create_export_new_episodes_jobs has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

        def _create_export_new_episodes_jobs(self, videoid, metadata, nfo_settings=None):
            """Create jobs data to export missing seasons and episodes"""
            tasks = []
            if metadata and 'seasons' in metadata[0]:
                for season in metadata[0]['seasons']:
    Severity: Minor
    Found in resources/lib/kodi/library_tasks.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _get_preferred_subtitle_language has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

        def _get_preferred_subtitle_language(self):
            """
            Get the language code of the preferred subtitle as set in Kodi Player setting
            :return: The language code (as ISO with 2 letters) or 'None' if disabled
            """
    Severity: Minor
    Found in resources/lib/services/playback/am_stream_continuity.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function auto_update_library has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

        def auto_update_library(self, sync_with_mylist, show_prg_dialog=True, show_nfo_dialog=False, clear_on_cancel=False,
                                update_profiles=False):
            """
            Perform an auto update of the exported items in to Kodi library.
            - The main purpose is check if there are new seasons/episodes.
    Severity: Minor
    Found in resources/lib/kodi/library.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language