Chiliec/yii2-vote

View on GitHub
actions/VoteAction.php

Summary

Maintainability
C
1 day
Test Coverage

Function run has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function run()
    {
        if (Yii::$app->request->getIsAjax()) {
            Yii::$app->response->format = Response::FORMAT_JSON;
            if (null === $modelId = (int)Yii::$app->request->post('modelId')) {
Severity: Minor
Found in actions/VoteAction.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        if (Yii::$app->request->getIsAjax()) {
            Yii::$app->response->format = Response::FORMAT_JSON;
            if (null === $modelId = (int)Yii::$app->request->post('modelId')) {
Severity: Major
Found in actions/VoteAction.php - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

                    return ['content' => Yii::t('vote', 'The model is not registered')];
    Severity: Major
    Found in actions/VoteAction.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                              return ['content' => Yii::t('vote', 'Your vote is accepted. Thanks!'), 'success' => true];
      Severity: Major
      Found in actions/VoteAction.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                                return ['content' => Yii::t('vote', 'Your vote has been changed. Thanks!'), 'success' => true, 'changed' => true];
        Severity: Major
        Found in actions/VoteAction.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return ['content' => Yii::t('vote', 'Validation error')];
          Severity: Major
          Found in actions/VoteAction.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                    return ['content' => Yii::t('vote', 'Validation error')];
            Severity: Major
            Found in actions/VoteAction.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                      return ['content' => Yii::t('vote', 'Thanks for your opinion'), 'success' => true];
              Severity: Major
              Found in actions/VoteAction.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return ['content' => Yii::t('vote', 'You have already voted!')];
                Severity: Major
                Found in actions/VoteAction.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return ['content' => Yii::t('vote', 'The user is not recognized')];
                  Severity: Major
                  Found in actions/VoteAction.php - About 30 mins to fix

                    There are no issues that match your filters.

                    Category
                    Status