Chiliec/yii2-vote

View on GitHub

Showing 14 of 16 total issues

Function run has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function run()
    {
        if (Yii::$app->request->getIsAjax()) {
            Yii::$app->response->format = Response::FORMAT_JSON;
            if (null === $modelId = (int)Yii::$app->request->post('modelId')) {
Severity: Minor
Found in actions/VoteAction.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        if (Yii::$app->request->getIsAjax()) {
            Yii::$app->response->format = Response::FORMAT_JSON;
            if (null === $modelId = (int)Yii::$app->request->post('modelId')) {
Severity: Major
Found in actions/VoteAction.php - About 2 hrs to fix

    Method init has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function init()
        {
            parent::init();
            if (!isset($this->model)) {
                throw new InvalidParamException(Yii::t('vote', 'Model not configurated'));
    Severity: Minor
    Found in widgets/Vote.php - About 1 hr to fix

      Function getModelIdByName has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function getModelIdByName($modelName)
          {
              if (null !== $models = Yii::$app->getModule('vote')->models) {
                  $modelId = array_search($modelName, $models);
                  if (is_int($modelId)) {
      Severity: Minor
      Found in models/Rating.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function up has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function up()
          {
              if ($this->db->driverName !== 'sqlite') {
                  if ($this->db->driverName === 'pgsql') {
                      $this->execute('ALTER TABLE ' . $this->tableName . ' ALTER COLUMN "date" DROP DEFAULT');
      Severity: Minor
      Found in migrations/m150127_165542_update_rating_table.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getModelNameById has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function getModelNameById($modelId)
          {
              if (null !== $models = Yii::$app->getModule('vote')->models) {
                  if (isset($models[$modelId])) {
                      if (is_array($models[$modelId])) {
      Severity: Minor
      Found in models/Rating.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                              return ['content' => Yii::t('vote', 'Validation error')];
      Severity: Major
      Found in actions/VoteAction.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return ['content' => Yii::t('vote', 'The model is not registered')];
        Severity: Major
        Found in actions/VoteAction.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return ['content' => Yii::t('vote', 'Validation error')];
          Severity: Major
          Found in actions/VoteAction.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                    return ['content' => Yii::t('vote', 'Your vote has been changed. Thanks!'), 'success' => true, 'changed' => true];
            Severity: Major
            Found in actions/VoteAction.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return ['content' => Yii::t('vote', 'The user is not recognized')];
              Severity: Major
              Found in actions/VoteAction.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return ['content' => Yii::t('vote', 'You have already voted!')];
                Severity: Major
                Found in actions/VoteAction.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                          return ['content' => Yii::t('vote', 'Your vote is accepted. Thanks!'), 'success' => true];
                  Severity: Major
                  Found in actions/VoteAction.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                            return ['content' => Yii::t('vote', 'Thanks for your opinion'), 'success' => true];
                    Severity: Major
                    Found in actions/VoteAction.php - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language