Chocobozzz/PeerTube

View on GitHub
client/src/app/+admin/admin.component.ts

Summary

Maintainability
D
2 days
Test Coverage

Function buildModerationItems has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private buildModerationItems () {
    const moderationItems: TopMenuDropdownParam = {
      label: $localize`Moderation`,
      children: []
    }
Severity: Minor
Found in client/src/app/+admin/admin.component.ts - About 1 hr to fix

    Function buildSystemItems has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private buildSystemItems () {
        const systemItems: TopMenuDropdownParam = {
          label: $localize`System`,
          children: []
        }
    Severity: Minor
    Found in client/src/app/+admin/admin.component.ts - About 1 hr to fix

      Function buildOverviewItems has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private buildOverviewItems () {
          const overviewItems: TopMenuDropdownParam = {
            label: $localize`Overview`,
            children: []
          }
      Severity: Minor
      Found in client/src/app/+admin/admin.component.ts - About 1 hr to fix

        Function buildModerationItems has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          private buildModerationItems () {
            const moderationItems: TopMenuDropdownParam = {
              label: $localize`Moderation`,
              children: []
            }
        Severity: Minor
        Found in client/src/app/+admin/admin.component.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function buildSystemItems has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          private buildSystemItems () {
            const systemItems: TopMenuDropdownParam = {
              label: $localize`System`,
              children: []
            }
        Severity: Minor
        Found in client/src/app/+admin/admin.component.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          private buildConfigurationItems () {
            if (this.hasRight(UserRight.MANAGE_CONFIGURATION)) {
              this.menuEntries.push({ label: $localize`Configuration`, routerLink: '/admin/config' })
            }
          }
        Severity: Major
        Found in client/src/app/+admin/admin.component.ts and 1 other location - About 1 hr to fix
        client/src/app/+admin/admin.component.ts on lines 173..177

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          private buildPluginItems () {
            if (this.hasRight(UserRight.MANAGE_PLUGINS)) {
              this.menuEntries.push({ label: $localize`Plugins/Themes`, routerLink: '/admin/plugins' })
            }
          }
        Severity: Major
        Found in client/src/app/+admin/admin.component.ts and 1 other location - About 1 hr to fix
        client/src/app/+admin/admin.component.ts on lines 167..171

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

            if (this.hasRight(UserRight.MANAGE_ACCOUNTS_BLOCKLIST)) {
              moderationItems.children.push({
                label: $localize`Muted accounts`,
                routerLink: '/admin/moderation/blocklist/accounts',
                iconName: 'user-x'
        Severity: Major
        Found in client/src/app/+admin/admin.component.ts and 10 other locations - About 1 hr to fix
        client/src/app/+admin/admin.component.ts on lines 53..59
        client/src/app/+admin/admin.component.ts on lines 72..78
        client/src/app/+admin/admin.component.ts on lines 116..122
        client/src/app/+admin/admin.component.ts on lines 124..130
        client/src/app/+admin/admin.component.ts on lines 132..138
        client/src/app/+admin/admin.component.ts on lines 148..154
        client/src/app/+admin/admin.component.ts on lines 156..162
        client/src/app/+admin/admin.component.ts on lines 199..205
        client/src/app/+admin/admin.component.ts on lines 207..213
        client/src/app/+admin/admin.component.ts on lines 215..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

            if (this.hasRight(UserRight.MANAGE_DEBUG)) {
              systemItems.children.push({
                label: $localize`Debug`,
                iconName: 'cog',
                routerLink: '/admin/system/debug'
        Severity: Major
        Found in client/src/app/+admin/admin.component.ts and 10 other locations - About 1 hr to fix
        client/src/app/+admin/admin.component.ts on lines 53..59
        client/src/app/+admin/admin.component.ts on lines 72..78
        client/src/app/+admin/admin.component.ts on lines 116..122
        client/src/app/+admin/admin.component.ts on lines 124..130
        client/src/app/+admin/admin.component.ts on lines 132..138
        client/src/app/+admin/admin.component.ts on lines 140..146
        client/src/app/+admin/admin.component.ts on lines 148..154
        client/src/app/+admin/admin.component.ts on lines 156..162
        client/src/app/+admin/admin.component.ts on lines 199..205
        client/src/app/+admin/admin.component.ts on lines 207..213

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

            if (this.hasRight(UserRight.SEE_ALL_COMMENTS)) {
              overviewItems.children.push({
                label: $localize`Comments`,
                routerLink: '/admin/comments',
                iconName: 'message-circle'
        Severity: Major
        Found in client/src/app/+admin/admin.component.ts and 10 other locations - About 1 hr to fix
        client/src/app/+admin/admin.component.ts on lines 53..59
        client/src/app/+admin/admin.component.ts on lines 116..122
        client/src/app/+admin/admin.component.ts on lines 124..130
        client/src/app/+admin/admin.component.ts on lines 132..138
        client/src/app/+admin/admin.component.ts on lines 140..146
        client/src/app/+admin/admin.component.ts on lines 148..154
        client/src/app/+admin/admin.component.ts on lines 156..162
        client/src/app/+admin/admin.component.ts on lines 199..205
        client/src/app/+admin/admin.component.ts on lines 207..213
        client/src/app/+admin/admin.component.ts on lines 215..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

            if (this.hasRight(UserRight.MANAGE_JOBS)) {
              systemItems.children.push({
                label: $localize`Local jobs`,
                iconName: 'circle-tick',
                routerLink: '/admin/system/jobs'
        Severity: Major
        Found in client/src/app/+admin/admin.component.ts and 10 other locations - About 1 hr to fix
        client/src/app/+admin/admin.component.ts on lines 53..59
        client/src/app/+admin/admin.component.ts on lines 72..78
        client/src/app/+admin/admin.component.ts on lines 116..122
        client/src/app/+admin/admin.component.ts on lines 124..130
        client/src/app/+admin/admin.component.ts on lines 132..138
        client/src/app/+admin/admin.component.ts on lines 140..146
        client/src/app/+admin/admin.component.ts on lines 148..154
        client/src/app/+admin/admin.component.ts on lines 156..162
        client/src/app/+admin/admin.component.ts on lines 207..213
        client/src/app/+admin/admin.component.ts on lines 215..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

            if (this.hasRight(UserRight.MANAGE_ABUSES)) {
              moderationItems.children.push({
                label: $localize`Reports`,
                routerLink: '/admin/moderation/abuses/list',
                iconName: 'flag'
        Severity: Major
        Found in client/src/app/+admin/admin.component.ts and 10 other locations - About 1 hr to fix
        client/src/app/+admin/admin.component.ts on lines 53..59
        client/src/app/+admin/admin.component.ts on lines 72..78
        client/src/app/+admin/admin.component.ts on lines 116..122
        client/src/app/+admin/admin.component.ts on lines 132..138
        client/src/app/+admin/admin.component.ts on lines 140..146
        client/src/app/+admin/admin.component.ts on lines 148..154
        client/src/app/+admin/admin.component.ts on lines 156..162
        client/src/app/+admin/admin.component.ts on lines 199..205
        client/src/app/+admin/admin.component.ts on lines 207..213
        client/src/app/+admin/admin.component.ts on lines 215..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

            if (this.hasRight(UserRight.MANAGE_INSTANCE_WATCHED_WORDS)) {
              moderationItems.children.push({
                label: $localize`Watched words`,
                routerLink: '/admin/moderation/watched-words/list',
                iconName: 'eye-open'
        Severity: Major
        Found in client/src/app/+admin/admin.component.ts and 10 other locations - About 1 hr to fix
        client/src/app/+admin/admin.component.ts on lines 53..59
        client/src/app/+admin/admin.component.ts on lines 72..78
        client/src/app/+admin/admin.component.ts on lines 116..122
        client/src/app/+admin/admin.component.ts on lines 124..130
        client/src/app/+admin/admin.component.ts on lines 132..138
        client/src/app/+admin/admin.component.ts on lines 140..146
        client/src/app/+admin/admin.component.ts on lines 148..154
        client/src/app/+admin/admin.component.ts on lines 199..205
        client/src/app/+admin/admin.component.ts on lines 207..213
        client/src/app/+admin/admin.component.ts on lines 215..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

            if (this.hasRight(UserRight.MANAGE_VIDEO_BLACKLIST)) {
              moderationItems.children.push({
                label: $localize`Video blocks`,
                routerLink: '/admin/moderation/video-blocks/list',
                iconName: 'cross'
        Severity: Major
        Found in client/src/app/+admin/admin.component.ts and 10 other locations - About 1 hr to fix
        client/src/app/+admin/admin.component.ts on lines 53..59
        client/src/app/+admin/admin.component.ts on lines 72..78
        client/src/app/+admin/admin.component.ts on lines 116..122
        client/src/app/+admin/admin.component.ts on lines 124..130
        client/src/app/+admin/admin.component.ts on lines 140..146
        client/src/app/+admin/admin.component.ts on lines 148..154
        client/src/app/+admin/admin.component.ts on lines 156..162
        client/src/app/+admin/admin.component.ts on lines 199..205
        client/src/app/+admin/admin.component.ts on lines 207..213
        client/src/app/+admin/admin.component.ts on lines 215..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

            if (this.hasRight(UserRight.MANAGE_USERS)) {
              overviewItems.children.push({
                label: $localize`Users`,
                routerLink: '/admin/users',
                iconName: 'user'
        Severity: Major
        Found in client/src/app/+admin/admin.component.ts and 10 other locations - About 1 hr to fix
        client/src/app/+admin/admin.component.ts on lines 72..78
        client/src/app/+admin/admin.component.ts on lines 116..122
        client/src/app/+admin/admin.component.ts on lines 124..130
        client/src/app/+admin/admin.component.ts on lines 132..138
        client/src/app/+admin/admin.component.ts on lines 140..146
        client/src/app/+admin/admin.component.ts on lines 148..154
        client/src/app/+admin/admin.component.ts on lines 156..162
        client/src/app/+admin/admin.component.ts on lines 199..205
        client/src/app/+admin/admin.component.ts on lines 207..213
        client/src/app/+admin/admin.component.ts on lines 215..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

            if (this.hasRight(UserRight.MANAGE_REGISTRATIONS)) {
              moderationItems.children.push({
                label: $localize`Registrations`,
                routerLink: '/admin/moderation/registrations/list',
                iconName: 'user'
        Severity: Major
        Found in client/src/app/+admin/admin.component.ts and 10 other locations - About 1 hr to fix
        client/src/app/+admin/admin.component.ts on lines 53..59
        client/src/app/+admin/admin.component.ts on lines 72..78
        client/src/app/+admin/admin.component.ts on lines 124..130
        client/src/app/+admin/admin.component.ts on lines 132..138
        client/src/app/+admin/admin.component.ts on lines 140..146
        client/src/app/+admin/admin.component.ts on lines 148..154
        client/src/app/+admin/admin.component.ts on lines 156..162
        client/src/app/+admin/admin.component.ts on lines 199..205
        client/src/app/+admin/admin.component.ts on lines 207..213
        client/src/app/+admin/admin.component.ts on lines 215..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

            if (this.hasRight(UserRight.MANAGE_SERVERS_BLOCKLIST)) {
              moderationItems.children.push({
                label: $localize`Muted servers`,
                routerLink: '/admin/moderation/blocklist/servers',
                iconName: 'peertube-x'
        Severity: Major
        Found in client/src/app/+admin/admin.component.ts and 10 other locations - About 1 hr to fix
        client/src/app/+admin/admin.component.ts on lines 53..59
        client/src/app/+admin/admin.component.ts on lines 72..78
        client/src/app/+admin/admin.component.ts on lines 116..122
        client/src/app/+admin/admin.component.ts on lines 124..130
        client/src/app/+admin/admin.component.ts on lines 132..138
        client/src/app/+admin/admin.component.ts on lines 140..146
        client/src/app/+admin/admin.component.ts on lines 156..162
        client/src/app/+admin/admin.component.ts on lines 199..205
        client/src/app/+admin/admin.component.ts on lines 207..213
        client/src/app/+admin/admin.component.ts on lines 215..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

            if (this.hasRight(UserRight.MANAGE_LOGS)) {
              systemItems.children.push({
                label: $localize`Logs`,
                iconName: 'playlists',
                routerLink: '/admin/system/logs'
        Severity: Major
        Found in client/src/app/+admin/admin.component.ts and 10 other locations - About 1 hr to fix
        client/src/app/+admin/admin.component.ts on lines 53..59
        client/src/app/+admin/admin.component.ts on lines 72..78
        client/src/app/+admin/admin.component.ts on lines 116..122
        client/src/app/+admin/admin.component.ts on lines 124..130
        client/src/app/+admin/admin.component.ts on lines 132..138
        client/src/app/+admin/admin.component.ts on lines 140..146
        client/src/app/+admin/admin.component.ts on lines 148..154
        client/src/app/+admin/admin.component.ts on lines 156..162
        client/src/app/+admin/admin.component.ts on lines 199..205
        client/src/app/+admin/admin.component.ts on lines 215..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status