Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/app/+admin/plugins/plugin-search/plugin-search.component.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  constructor (
    private pluginService: PluginService,
    private pluginApiService: PluginApiService,
    private notifier: Notifier,
    private confirmService: ConfirmService,
Severity: Major
Found in client/src/app/+admin/plugins/plugin-search/plugin-search.component.ts and 9 other locations - About 1 hr to fix
client/src/app/+admin/plugins/plugin-list-installed/plugin-list-installed.component.ts on lines 49..57
client/src/app/+videos/+video-edit/video-add.component.ts on lines 73..80
client/src/app/+videos/+video-edit/video-update.resolver.ts on lines 17..25
client/src/app/+videos/+video-watch/shared/comment/video-comments.component.ts on lines 75..82
client/src/app/+videos/video-list/videos-list-common-page.component.ts on lines 49..57
client/src/app/menu/quick-settings-modal.component.ts on lines 34..42
client/src/app/shared/shared-custom-markup/peertube-custom-tags/channel-miniature-markup.component.ts on lines 40..47
client/src/app/shared/shared-main/video/video.service.ts on lines 64..71
client/src/app/shared/shared-video-playlist/video-playlist-element-miniature.component.ts on lines 72..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  onNearOfBottom () {
    if (!hasMoreItems(this.pagination)) return

    this.pagination.currentPage += 1
Severity: Major
Found in client/src/app/+admin/plugins/plugin-search/plugin-search.component.ts and 4 other locations - About 40 mins to fix
client/src/app/+accounts/account-video-channels/account-video-channels.component.ts on lines 153..159
client/src/app/+admin/plugins/plugin-list-installed/plugin-list-installed.component.ts on lines 96..102
client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts on lines 114..120
client/src/app/+video-channels/video-channel-playlists/video-channel-playlists.component.ts on lines 62..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const res = await this.confirmService.confirm(
      $localize`Please only install plugins or themes you trust, since they can execute any code on your instance.`,
      $localize`Install ${plugin.name}?`
    )
Severity: Minor
Found in client/src/app/+admin/plugins/plugin-search/plugin-search.component.ts and 1 other location - About 40 mins to fix
client/src/app/+admin/system/runners/runner-list/runner-list.component.ts on lines 64..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

@Component({
  selector: 'my-plugin-search',
  templateUrl: './plugin-search.component.html',
  styleUrls: [ './plugin-search.component.scss' ],
  standalone: true,
Severity: Major
Found in client/src/app/+admin/plugins/plugin-search/plugin-search.component.ts and 8 other locations - About 35 mins to fix
client/src/app/+admin/config/edit-custom-config/edit-live-configuration.component.ts on lines 14..115
client/src/app/+admin/config/edit-custom-config/edit-vod-transcoding.component.ts on lines 15..155
client/src/app/+manage/video-channel-edit/video-channel-update.component.ts on lines 26..210
client/src/app/+videos/+video-watch/shared/comment/video-comment.component.ts on lines 19..255
client/src/app/shared/shared-main/menu/top-menu-dropdown.component.ts on lines 27..144
client/src/app/shared/shared-moderation/report-modals/video-report.component.ts on lines 21..124
client/src/app/shared/shared-video-miniature/download/video-generate-download.component.ts on lines 16..134
client/src/app/shared/shared-video-miniature/video-actions-dropdown.component.ts on lines 45..592

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  reloadPlugins () {
    this.pagination.currentPage = 1
    this.plugins = []

    this.loadMorePlugins()
Severity: Minor
Found in client/src/app/+admin/plugins/plugin-search/plugin-search.component.ts and 1 other location - About 30 mins to fix
client/src/app/+admin/plugins/plugin-list-installed/plugin-list-installed.component.ts on lines 75..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status