Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/app/+my-account/my-account-import-export/my-account-export.component.ts

Summary

Maintainability
A
1 hr
Test Coverage

Function requestNewArchive has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  requestNewArchive () {
    if (this.requestingArchive) return
    this.requestingArchive = true

    let baseObs = of<any>(true)
Severity: Minor
Found in client/src/app/+my-account/my-account-import-export/my-account-export.component.ts - About 1 hr to fix

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

    @Component({
  selector: 'my-account-export',
  templateUrl: './my-account-export.component.html',
  styleUrls: [ './my-account-export.component.scss' ],
  standalone: true,
    Severity: Major
    Found in client/src/app/+my-account/my-account-import-export/my-account-export.component.ts and 11 other locations - About 30 mins to fix
    client/src/app/+about/about-instance/about-instance.component.ts on lines 16..115
    client/src/app/+admin/plugins/plugin-list-installed/plugin-list-installed.component.ts on lines 17..216
    client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 19..225
    client/src/app/+videos/+video-watch/shared/recommendations/recommended-videos.component.ts on lines 14..108
    client/src/app/menu/notification-dropdown.component.ts on lines 13..112
    client/src/app/shared/shared-forms/advanced-input-filter.component.ts on lines 25..187
    client/src/app/shared/shared-forms/dynamic-form-field.component.ts on lines 10..42
    client/src/app/shared/shared-moderation/report-modals/account-report.component.ts on lines 19..111
    client/src/app/shared/shared-moderation/report-modals/comment-report.component.ts on lines 19..110
    client/src/app/shared/shared-user-settings/user-video-settings.component.ts on lines 17..153
    client/src/app/shared/shared-video-miniature/download/video-download.component.ts on lines 20..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status