Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/app/+my-account/my-account-import-export/my-account-import.component.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  private handleUploadError (err: HttpErrorResponse) {
    // Reset progress
    this.uploadPercents = 0
    this.enableRetryAfterError = true
Severity: Major
Found in client/src/app/+my-account/my-account-import-export/my-account-import.component.ts and 1 other location - About 4 hrs to fix
client/src/app/+videos/+video-edit/video-add-components/video-upload.component.ts on lines 323..338

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

      case 'error': {
        if (!this.alreadyRefreshedToken && state.responseStatus === HttpStatusCode.UNAUTHORIZED_401) {
          this.alreadyRefreshedToken = true

          return this.refreshTokenAndRetryUpload()
Severity: Major
Found in client/src/app/+my-account/my-account-import-export/my-account-import.component.ts and 2 other locations - About 1 hr to fix
client/src/app/+videos/+video-edit/video-add-components/video-upload.component.ts on lines 168..177
client/src/app/+videos/+video-edit/video-update.component.ts on lines 340..349

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

  constructor (
    private authService: AuthService,
    private server: ServerService,
    private userImportExportService: UserImportExportService,
    private resumableUploadService: UploadxService,
Severity: Major
Found in client/src/app/+my-account/my-account-import-export/my-account-import.component.ts and 14 other locations - About 55 mins to fix
client/src/app/+accounts/account-video-channels/account-video-channels.component.ts on lines 65..71
client/src/app/+my-account/my-account-applications/my-account-applications.component.ts on lines 22..28
client/src/app/+my-account/my-account-settings/my-account-danger-zone/my-account-danger-zone.component.ts on lines 12..18
client/src/app/+my-account/my-account-settings/my-account-two-factor/my-account-two-factor.component.ts on lines 39..46
client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts on lines 63..69
client/src/app/+signup/+register/register.component.ts on lines 82..88
client/src/app/+signup/+verify-account/verify-account-email/verify-account-email.component.ts on lines 28..35
client/src/app/+videos/video-list/video-user-subscriptions.component.ts on lines 38..46
client/src/app/core/theme/theme.service.ts on lines 24..30
client/src/app/menu/notification-dropdown.component.ts on lines 43..50
client/src/app/shared/shared-main/users/user-notification.service.ts on lines 16..22
client/src/app/shared/shared-search/search.service.ts on lines 25..31
client/src/app/shared/shared-user-subscription/subscribe-button.component.ts on lines 48..54
client/src/app/shared/shared-video-miniature/download/video-download.component.ts on lines 52..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  retryUpload () {
    this.enableRetryAfterError = false
    this.error = ''
    this.uploadFile(this.fileToUpload)
  }
Severity: Minor
Found in client/src/app/+my-account/my-account-import-export/my-account-import.component.ts and 1 other location - About 30 mins to fix
client/src/app/+videos/+video-edit/video-add-components/video-upload.component.ts on lines 243..247

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status