Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts

Summary

Maintainability
C
1 day
Test Coverage

Function buildChartOptions has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private buildChartOptions () {
    const channelsMinimumDailyViews = Math.min(...this.videoChannels.map(v => minBy(v.viewsPerDay, 'views').views))
    const channelsMaximumDailyViews = Math.max(...this.videoChannels.map(v => maxBy(v.viewsPerDay, 'views').views))

    this.chartOptions = {
Severity: Minor
Found in client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts - About 1 hr to fix

    Function loadMoreVideoChannels has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private loadMoreVideoChannels () {
    if (this.pagesDone.has(this.pagination.currentPage)) return
    this.pagesDone.add(this.pagination.currentPage)

    return this.authService.userInformationLoaded
    Severity: Minor
    Found in client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          this.videoChannelService.removeVideoChannel(videoChannel)
      .subscribe({
        next: () => {
          this.videoChannels = this.videoChannels.filter(c => c.id !== videoChannel.id)
          this.notifier.success($localize`Video channel ${videoChannel.displayName} deleted.`)
      Severity: Major
      Found in client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts and 1 other location - About 4 hrs to fix
      client/src/app/+my-library/my-video-playlists/my-video-playlists.component.ts on lines 63..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 15 locations. Consider refactoring.
      Open

        constructor (
    private authService: AuthService,
    private notifier: Notifier,
    private confirmService: ConfirmService,
    private videoChannelService: VideoChannelService,
      Severity: Major
      Found in client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts and 14 other locations - About 55 mins to fix
      client/src/app/+accounts/account-video-channels/account-video-channels.component.ts on lines 65..71
      client/src/app/+my-account/my-account-applications/my-account-applications.component.ts on lines 22..28
      client/src/app/+my-account/my-account-import-export/my-account-import.component.ts on lines 38..44
      client/src/app/+my-account/my-account-settings/my-account-danger-zone/my-account-danger-zone.component.ts on lines 12..18
      client/src/app/+my-account/my-account-settings/my-account-two-factor/my-account-two-factor.component.ts on lines 39..46
      client/src/app/+signup/+register/register.component.ts on lines 82..88
      client/src/app/+signup/+verify-account/verify-account-email/verify-account-email.component.ts on lines 28..35
      client/src/app/+videos/video-list/video-user-subscriptions.component.ts on lines 38..46
      client/src/app/core/theme/theme.service.ts on lines 24..30
      client/src/app/menu/notification-dropdown.component.ts on lines 43..50
      client/src/app/shared/shared-main/users/user-notification.service.ts on lines 16..22
      client/src/app/shared/shared-search/search.service.ts on lines 25..31
      client/src/app/shared/shared-user-subscription/subscribe-button.component.ts on lines 48..54
      client/src/app/shared/shared-video-miniature/download/video-download.component.ts on lines 52..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        getTotalTitle () {
    return formatICU(
      $localize`You have ${this.pagination.totalItems} {total, plural, =1 {channel} other {channels}}`,
      { total: this.pagination.totalItems }
    )
      Severity: Major
      Found in client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts and 5 other locations - About 50 mins to fix
      client/src/app/+my-library/my-follows/my-followers.component.ts on lines 78..83
      client/src/app/+my-library/my-follows/my-subscriptions.component.ts on lines 61..66
      client/src/app/+my-library/my-history/my-history.component.ts on lines 166..171
      client/src/app/+my-library/my-video-playlists/my-video-playlists.component.ts on lines 93..98
      client/src/app/+my-library/my-videos/my-videos.component.ts on lines 247..252

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

        onNearOfBottom () {
    if (!hasMoreItems(this.pagination)) return

    this.pagination.currentPage += 1
      Severity: Major
      Found in client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts and 4 other locations - About 40 mins to fix
      client/src/app/+accounts/account-video-channels/account-video-channels.component.ts on lines 153..159
      client/src/app/+admin/plugins/plugin-list-installed/plugin-list-installed.component.ts on lines 96..102
      client/src/app/+admin/plugins/plugin-search/plugin-search.component.ts on lines 128..134
      client/src/app/+video-channels/video-channel-playlists/video-channel-playlists.component.ts on lines 62..67

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const channelsMaximumDailyViews = Math.max(...this.videoChannels.map(v => maxBy(v.viewsPerDay, 'views').views))
      Severity: Minor
      Found in client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts and 1 other location - About 35 mins to fix
      client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts on lines 169..169

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const channelsMinimumDailyViews = Math.min(...this.videoChannels.map(v => minBy(v.viewsPerDay, 'views').views))
      Severity: Minor
      Found in client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts and 1 other location - About 35 mins to fix
      client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts on lines 170..170

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status