Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/app/+my-library/my-videos/my-videos.component.ts

Summary

Maintainability
C
1 day
Test Coverage

Function deleteSelectedVideos has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async deleteSelectedVideos () {
    const toDeleteVideosIds = Object.entries(this.selection)
                                    .filter(([ _k, v ]) => v === true)
                                    .map(([ k, _v ]) => parseInt(k, 10))
Severity: Minor
Found in client/src/app/+my-library/my-videos/my-videos.component.ts - About 1 hr to fix

    Function ngOnInit has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      ngOnInit () {
    this.buildActions()

    this.user = this.authService.getUser()
    Severity: Minor
    Found in client/src/app/+my-library/my-videos/my-videos.component.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        constructor (
    protected router: Router,
    protected serverService: ServerService,
    protected route: ActivatedRoute,
    protected authService: AuthService,
      Severity: Major
      Found in client/src/app/+my-library/my-videos/my-videos.component.ts and 1 other location - About 2 hrs to fix
      client/src/app/+search/search.component.ts on lines 86..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 82.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const res = await this.confirmService.confirm(
      formatICU(
        $localize`Do you really want to delete {length, plural, =1 {this video} other {{length} videos}}?`,
        { length: toDeleteVideosIds.length }
      ),
      Severity: Major
      Found in client/src/app/+my-library/my-videos/my-videos.component.ts and 1 other location - About 1 hr to fix
      client/src/app/+admin/overview/users/user-list/user-list.component.ts on lines 254..260

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

        miniatureDisplayOptions: MiniatureDisplayOptions = {
    date: true,
    views: true,
    by: true,
    privacyLabel: false,
      Severity: Major
      Found in client/src/app/+my-library/my-videos/my-videos.component.ts and 7 other locations - About 50 mins to fix
      client/src/app/+accounts/account-video-channels/account-video-channels.component.ts on lines 52..61
      client/src/app/+search/search.component.ts on lines 59..68
      client/src/app/+video-channels/video-channel-videos/video-channel-videos.component.ts on lines 28..37
      client/src/app/shared/shared-custom-markup/peertube-custom-tags/playlist-miniature-markup.component.ts on lines 30..39
      client/src/app/shared/shared-custom-markup/peertube-custom-tags/video-miniature-markup.component.ts on lines 30..39
      client/src/app/shared/shared-custom-markup/peertube-custom-tags/videos-list-markup.component.ts on lines 41..50
      client/src/app/shared/shared-video-miniature/videos-list.component.ts on lines 116..125

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        getTotalTitle () {
    return formatICU(
      $localize`You have ${this.pagination.totalItems} {total, plural, =1 {video} other {videos}}`,
      { total: this.pagination.totalItems }
    )
      Severity: Major
      Found in client/src/app/+my-library/my-videos/my-videos.component.ts and 5 other locations - About 50 mins to fix
      client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts on lines 227..232
      client/src/app/+my-library/my-follows/my-followers.component.ts on lines 78..83
      client/src/app/+my-library/my-follows/my-subscriptions.component.ts on lines 61..66
      client/src/app/+my-library/my-history/my-history.component.ts on lines 166..171
      client/src/app/+my-library/my-video-playlists/my-video-playlists.component.ts on lines 93..98

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          return this.videoService.getMyVideos({
      videoPagination: newPagination,
      sort: this.sort,
      userChannels: this.userChannels,
      search: this.search
      Severity: Minor
      Found in client/src/app/+my-library/my-videos/my-videos.component.ts and 1 other location - About 50 mins to fix
      client/src/app/+admin/system/jobs/jobs.component.ts on lines 160..174

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if (this.route.snapshot.queryParams['search']) {
      this.search = this.route.snapshot.queryParams['search']
    }
      Severity: Minor
      Found in client/src/app/+my-library/my-videos/my-videos.component.ts and 1 other location - About 45 mins to fix
      client/src/app/+my-library/my-follows/my-followers.component.ts on lines 42..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status