Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/app/+video-studio/edit/video-studio-edit.component.ts

Summary

Maintainability
C
1 day
Test Coverage

Function buildTasks has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private buildTasks () {
    const tasks: VideoStudioTask[] = []
    const value = this.form.value

    const cut = value['cut']
Severity: Minor
Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts - About 1 hr to fix

    Function buildTasks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      private buildTasks () {
    const tasks: VideoStudioTask[] = []
    const value = this.form.value

    const cut = value['cut']
    Severity: Minor
    Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

              return $localize`Video will begin at ${secondsToTime(start)}`
    Severity: Major
    Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return ''
      Severity: Major
      Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                  return $localize`Video will stop at ${secondsToTime(end)}`
        Severity: Major
        Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return this.videoStudioService.editVideo(this.video.uuid, tasks)
      .subscribe({
        next: () => {
          this.notifier.success($localize`Edition tasks created.`)
          Severity: Major
          Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts - About 30 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              constructor (
    protected formReactiveService: FormReactiveService,
    private serverService: ServerService,
    private notifier: Notifier,
    private router: Router,
            Severity: Major
            Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts and 2 other locations - About 2 hrs to fix
            client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.ts on lines 87..98
            client/src/app/+admin/overview/users/user-list/user-list.component.ts on lines 109..120

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 86.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                if (value['add-watermark']?.['file']) {
      tasks.push({
        name: 'add-watermark',
        options: {
          file: value['add-watermark']['file']
            Severity: Major
            Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts and 2 other locations - About 50 mins to fix
            client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 195..202
            client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 204..211

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                if (value['add-outro']?.['file']) {
      tasks.push({
        name: 'add-outro',
        options: {
          file: value['add-outro']['file']
            Severity: Major
            Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts and 2 other locations - About 50 mins to fix
            client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 195..202
            client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 213..220

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                if (value['add-intro']?.['file']) {
      tasks.push({
        name: 'add-intro',
        options: {
          file: value['add-intro']['file']
            Severity: Major
            Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts and 2 other locations - About 50 mins to fix
            client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 204..211
            client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 213..220

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  if (t.name === 'add-outro') {
        return $localize`"${this.getFilename(t.options.file)}" will be added at the end of the video`
      }
            Severity: Minor
            Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts and 2 other locations - About 35 mins to fix
            client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 142..144
            client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 150..152

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  if (t.name === 'add-watermark') {
        return $localize`"${this.getFilename(t.options.file)}" image watermark will be added to the video`
      }
            Severity: Minor
            Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts and 2 other locations - About 35 mins to fix
            client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 142..144
            client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 146..148

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  if (t.name === 'add-intro') {
        return $localize`"${this.getFilename(t.options.file)}" will be added at the beginning of the video`
      }
            Severity: Minor
            Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts and 2 other locations - About 35 mins to fix
            client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 146..148
            client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 150..152

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

            @Component({
  selector: 'my-video-studio-edit',
  templateUrl: './video-studio-edit.component.html',
  styleUrls: [ './video-studio-edit.component.scss' ],
  standalone: true,
            Severity: Major
            Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts and 11 other locations - About 30 mins to fix
            client/src/app/+about/about-instance/about-instance.component.ts on lines 16..115
            client/src/app/+admin/plugins/plugin-list-installed/plugin-list-installed.component.ts on lines 17..216
            client/src/app/+my-account/my-account-import-export/my-account-export.component.ts on lines 14..128
            client/src/app/+videos/+video-watch/shared/recommendations/recommended-videos.component.ts on lines 14..108
            client/src/app/menu/notification-dropdown.component.ts on lines 13..112
            client/src/app/shared/shared-forms/advanced-input-filter.component.ts on lines 25..187
            client/src/app/shared/shared-forms/dynamic-form-field.component.ts on lines 10..42
            client/src/app/shared/shared-moderation/report-modals/account-report.component.ts on lines 19..111
            client/src/app/shared/shared-moderation/report-modals/comment-report.component.ts on lines 19..110
            client/src/app/shared/shared-user-settings/user-video-settings.component.ts on lines 17..153
            client/src/app/shared/shared-video-miniature/download/video-download.component.ts on lines 20..123

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status