Chocobozzz/PeerTube

View on GitHub
client/src/app/+videos/+video-edit/shared/caption/video-caption-edit-modal-content.component.ts

Summary

Maintainability
C
1 day
Test Coverage

File video-caption-edit-modal-content.component.ts has 269 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { NgClass, NgForOf, NgIf } from '@angular/common'
import { AfterViewInit, ChangeDetectorRef, Component, ElementRef, EventEmitter, Input, OnInit, Output, ViewChild } from '@angular/core'
import { FormsModule, ReactiveFormsModule } from '@angular/forms'
import { VIDEO_CAPTION_FILE_CONTENT_VALIDATOR } from '@app/shared/form-validators/video-captions-validators'
import { FormReactive } from '@app/shared/shared-forms/form-reactive'

    VideoCaptionEditModalContentComponent has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Component({
      styleUrls: [ './video-caption-edit-modal-content.component.scss' ],
      templateUrl: './video-caption-edit-modal-content.component.html',
      standalone: true,
      imports: [

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

        constructor (
          protected openedModal: NgbActiveModal,
          protected formReactiveService: FormReactiveService,
          private videoCaptionService: VideoCaptionService,
          private serverService: ServerService,
      client/src/app/+about/about-instance/contact-admin-modal.component.ts on lines 41..50
      client/src/app/+admin/plugins/plugin-show-installed/plugin-show-installed.component.ts on lines 30..39
      client/src/app/+manage/video-channel-edit/video-channel-create.component.ts on lines 50..59
      client/src/app/+my-library/my-video-channel-syncs/video-channel-sync-edit/video-channel-sync-edit.component.ts on lines 31..40
      client/src/app/+my-library/my-video-playlists/my-video-playlist-create.component.ts on lines 46..55
      client/src/app/shared/shared-abuse-list/abuse-message-modal.component.ts on lines 37..46
      client/src/app/shared/shared-user-settings/user-interface-settings.component.ts on lines 29..38

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        async videoTimeForSegmentEnd (segment: Segment) {
          segment.endMs = await this.player.getCurrentTime() * 1000
          segment.endFormatted = millisecondsToVttTime(segment.endMs)
        }
      client/src/app/+videos/+video-edit/shared/caption/video-caption-edit-modal-content.component.ts on lines 245..248

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        async videoTimeForSegmentStart (segment: Segment) {
          segment.startMs = await this.player.getCurrentTime() * 1000
          segment.startFormatted = millisecondsToVttTime(segment.startMs)
        }
      client/src/app/+videos/+video-edit/shared/caption/video-caption-edit-modal-content.component.ts on lines 250..253

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        getSegmentClasses (segment: Segment) {
          return { active: this.activeSegment === segment, ['segment-' + segment.id]: true }
        }
      client/src/app/+videos/+video-watch/shared/player-widgets/video-transcription.component.ts on lines 118..120

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status