Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/app/+videos/+video-edit/video-add-components/video-go-live.component.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Function goLive has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  goLive () {
    if (this.isOrHasGoingLive) return
    this.isOrHasGoingLive = true

    const name = 'Live'
Severity: Minor
Found in client/src/app/+videos/+video-edit/video-add-components/video-go-live.component.ts - About 1 hr to fix

    Function updateSecondStep has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async updateSecondStep () {
    if (!await this.isFormValid()) return

    this.isUpdatingVideo = true
    Severity: Minor
    Found in client/src/app/+videos/+video-edit/video-add-components/video-go-live.component.ts - About 1 hr to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        constructor (
    protected formReactiveService: FormReactiveService,
    protected loadingBar: LoadingBarService,
    protected notifier: Notifier,
    protected authService: AuthService,
      Severity: Major
      Found in client/src/app/+videos/+video-edit/video-add-components/video-go-live.component.ts and 3 other locations - About 3 hrs to fix
      client/src/app/+admin/overview/videos/video-list.component.ts on lines 96..110
      client/src/app/+videos/+video-edit/video-add-components/video-import-torrent.component.ts on lines 69..83
      client/src/app/+videos/+video-edit/video-add-components/video-import-url.component.ts on lines 67..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 113.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        getPermanentLiveDescription () {
    if (this.isReplayAllowed()) {
      return $localize`Stream multiple times, replays will be separate videos`
    }
      Severity: Major
      Found in client/src/app/+videos/+video-edit/video-add-components/video-go-live.component.ts and 3 other locations - About 35 mins to fix
      client/src/app/+admin/moderation/registration-list/process-registration-modal.component.ts on lines 74..80
      client/src/app/+videos/+video-edit/video-add-components/video-go-live.component.ts on lines 212..218
      client/src/app/core/theme/theme.service.ts on lines 45..51

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        getNormalLiveDescription () {
    if (this.isReplayAllowed()) {
      return $localize`Stream only once, replay will replace your live`
    }
      Severity: Major
      Found in client/src/app/+videos/+video-edit/video-add-components/video-go-live.component.ts and 3 other locations - About 35 mins to fix
      client/src/app/+admin/moderation/registration-list/process-registration-modal.component.ts on lines 74..80
      client/src/app/+videos/+video-edit/video-add-components/video-go-live.component.ts on lines 220..226
      client/src/app/core/theme/theme.service.ts on lines 45..51

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status