Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/app/+videos/+video-edit/video-add.component.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Avoid too many return statements within this function.
Open

    return { canDeactivate: true }
Severity: Major
Found in client/src/app/+videos/+video-edit/video-add.component.ts - About 30 mins to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      @HostListener('window:beforeunload', [ '$event' ])
  onUnload (event: any) {
    const { text, canDeactivate } = this.canDeactivate()

    if (canDeactivate) return
    Severity: Major
    Found in client/src/app/+videos/+video-edit/video-add.component.ts and 1 other location - About 1 hr to fix
    client/src/app/+videos/+video-edit/video-update.component.ts on lines 152..160

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

      constructor (
    private auth: AuthService,
    private userService: UserService,
    private hooks: HooksService,
    private serverService: ServerService,
    Severity: Major
    Found in client/src/app/+videos/+video-edit/video-add.component.ts and 9 other locations - About 1 hr to fix
    client/src/app/+admin/plugins/plugin-list-installed/plugin-list-installed.component.ts on lines 49..57
    client/src/app/+admin/plugins/plugin-search/plugin-search.component.ts on lines 58..66
    client/src/app/+videos/+video-edit/video-update.resolver.ts on lines 17..25
    client/src/app/+videos/+video-watch/shared/comment/video-comments.component.ts on lines 75..82
    client/src/app/+videos/video-list/videos-list-common-page.component.ts on lines 49..57
    client/src/app/menu/quick-settings-modal.component.ts on lines 34..42
    client/src/app/shared/shared-custom-markup/peertube-custom-tags/channel-miniature-markup.component.ts on lines 40..47
    client/src/app/shared/shared-main/video/video.service.ts on lines 64..71
    client/src/app/shared/shared-video-playlist/video-playlist-element-miniature.component.ts on lines 72..79

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    @Component({
  selector: 'my-videos-add',
  templateUrl: './video-add.component.html',
  styleUrls: [ './video-add.component.scss' ],
  standalone: true,
    Severity: Major
    Found in client/src/app/+videos/+video-edit/video-add.component.ts and 4 other locations - About 55 mins to fix
    client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.ts on lines 51..488
    client/src/app/+admin/overview/users/user-edit/user-create.component.ts on lines 32..131
    client/src/app/+admin/overview/users/user-edit/user-update.component.ts on lines 30..187
    client/src/app/shared/shared-video-miniature/download/video-files-download.component.ts on lines 31..251

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      onNavChange (newActiveNav: string) {
    this.activeNav = newActiveNav

    this.router.navigate([], { fragment: this.activeNav })
  }
    Severity: Minor
    Found in client/src/app/+videos/+video-edit/video-add.component.ts and 1 other location - About 50 mins to fix
    client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.ts on lines 430..434

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status