Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/app/+videos/+video-watch/video-watch.component.ts

Summary

Maintainability
F
5 days
Test Coverage

File video-watch.component.ts has 797 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { NgClass, NgIf, NgTemplateOutlet, PlatformLocation } from '@angular/common'
import { Component, ElementRef, Inject, LOCALE_ID, NgZone, OnDestroy, OnInit, ViewChild } from '@angular/core'
import { ActivatedRoute, Router, RouterLink } from '@angular/router'
import {
  AuthService,
Severity: Major
Found in client/src/app/+videos/+video-watch/video-watch.component.ts - About 1 day to fix

    VideoWatchComponent has 43 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Component({
  selector: 'my-video-watch',
  templateUrl: './video-watch.component.html',
  styleUrls: [ './video-watch.component.scss' ],
  standalone: true,
    Severity: Minor
    Found in client/src/app/+videos/+video-watch/video-watch.component.ts - About 5 hrs to fix

      Function buildPeerTubePlayerLoadOptions has 119 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private buildPeerTubePlayerLoadOptions (options: {
    video: VideoDetails
    liveVideo: LiveVideo
    videoCaptions: VideoCaption[]
    videoChapters: VideoChapter[]
      Severity: Major
      Found in client/src/app/+videos/+video-watch/video-watch.component.ts - About 4 hrs to fix

        Function buildPeerTubePlayerLoadOptions has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
        Open

          private buildPeerTubePlayerLoadOptions (options: {
    video: VideoDetails
    liveVideo: LiveVideo
    videoCaptions: VideoCaption[]
    videoChapters: VideoChapter[]
        Severity: Minor
        Found in client/src/app/+videos/+video-watch/video-watch.component.ts - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function loadVideo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          private loadVideo (options: {
    videoId: string
    forceAutoplay: boolean
    liveRefresh?: boolean
    videoPassword?: string
        Severity: Major
        Found in client/src/app/+videos/+video-watch/video-watch.component.ts - About 2 hrs to fix

          Function loadPlayer has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            private async loadPlayer (options: {
    loggedInOrAnonymousUser: User
    forceAutoplay: boolean
  }) {
    const { loggedInOrAnonymousUser, forceAutoplay } = options
          Severity: Major
          Found in client/src/app/+videos/+video-watch/video-watch.component.ts - About 2 hrs to fix

            Function onVideoFetched has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              private async onVideoFetched (options: {
    video: VideoDetails
    live: LiveVideo
    videoCaptions: VideoCaption[]
    videoChapters: VideoChapter[]
            Severity: Minor
            Found in client/src/app/+videos/+video-watch/video-watch.component.ts - About 1 hr to fix

              Function buildHotkeysHelp has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                private buildHotkeysHelp (video: Video) {
    if (this.hotkeys.length !== 0) {
      this.hotkeysService.remove(this.hotkeys)
    }
              Severity: Minor
              Found in client/src/app/+videos/+video-watch/video-watch.component.ts - About 1 hr to fix

                Function loadVideo has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                  private loadVideo (options: {
    videoId: string
    forceAutoplay: boolean
    liveRefresh?: boolean
    videoPassword?: string
                Severity: Minor
                Found in client/src/app/+videos/+video-watch/video-watch.component.ts - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function buildPeerTubePlayerConstructorOptions has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  private buildPeerTubePlayerConstructorOptions (options: {
    urlOptions: URLOptions
  }): PeerTubePlayerContructorOptions {
    const { urlOptions } = options
                Severity: Minor
                Found in client/src/app/+videos/+video-watch/video-watch.component.ts - About 1 hr to fix

                  Function loadRouteQuery has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                    private loadRouteQuery () {
    this.queryParamsSub = this.route.queryParams.subscribe(queryParams => {
      // Handle the ?playlistPosition
      const positionParam = queryParams['playlistPosition']
      if (!positionParam) return
                  Severity: Minor
                  Found in client/src/app/+videos/+video-watch/video-watch.component.ts - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function buildHotkeysHelp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    private buildHotkeysHelp (video: Video) {
    if (this.hotkeys.length !== 0) {
      this.hotkeysService.remove(this.hotkeys)
    }
                  Severity: Minor
                  Found in client/src/app/+videos/+video-watch/video-watch.component.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        this.hotkeys = this.hotkeys.concat([
        new Hotkey('shift+s', () => {
          if (this.subscribeButton.isSubscribedToAll()) this.subscribeButton.unsubscribe()
          else this.subscribeButton.subscribe()
                  Severity: Major
                  Found in client/src/app/+videos/+video-watch/video-watch.component.ts and 1 other location - About 1 hr to fix
                  client/src/app/+video-channels/video-channels.component.ts on lines 106..113

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 70.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                        hlsOptions = {
        playlistUrl: hlsPlaylist.playlistUrl,
        segmentsSha256Url: hlsPlaylist.segmentsSha256Url,
        redundancyBaseUrls: hlsPlaylist.redundancies.map(r => r.baseUrl),
        trackerAnnounce: video.trackerUrls,
                  Severity: Major
                  Found in client/src/app/+videos/+video-watch/video-watch.component.ts and 1 other location - About 1 hr to fix
                  client/src/standalone/videos/shared/player-options-builder.ts on lines 412..418

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 63.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      const {
      video,
      live,
      videoCaptions,
      videoChapters,
                  Severity: Minor
                  Found in client/src/app/+videos/+video-watch/video-watch.component.ts and 1 other location - About 35 mins to fix
                  server/core/lib/plugins/plugin-helpers-builder.ts on lines 44..54

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status