Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/app/menu/menu.component.ts

Summary

Maintainability
C
1 day
Test Coverage

File menu.component.ts has 282 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { CommonModule, ViewportScroller } from '@angular/common'
import { Component, OnDestroy, OnInit, ViewChild } from '@angular/core'
import { Router, RouterLink, RouterLinkActive } from '@angular/router'
import {
  AuthService,
Severity: Minor
Found in client/src/app/menu/menu.component.ts - About 2 hrs to fix

    MenuComponent has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Component({
  selector: 'my-menu',
  templateUrl: './menu.component.html',
  styleUrls: [ './menu.component.scss' ],
  standalone: true,
    Severity: Minor
    Found in client/src/app/menu/menu.component.ts - About 2 hrs to fix

      Function ngOnInit has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        ngOnInit () {
    this.htmlServerConfig = this.serverService.getHTMLConfig()
    this.currentInterfaceLanguage = this.languageChooserModal.getCurrentLanguage()

    this.isLoggedIn = this.authService.isLoggedIn()
      Severity: Minor
      Found in client/src/app/menu/menu.component.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          private routesPerRight: { [role in UserRightType]?: string } = {
    [UserRight.MANAGE_USERS]: '/admin/users',
    [UserRight.MANAGE_SERVER_FOLLOW]: '/admin/friends',
    [UserRight.MANAGE_ABUSES]: '/admin/moderation/abuses',
    [UserRight.MANAGE_VIDEO_BLACKLIST]: '/admin/moderation/video-blocks',
        Severity: Major
        Found in client/src/app/menu/menu.component.ts and 1 other location - About 1 hr to fix
        server/core/initializers/constants.ts on lines 604..611

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

        @Component({
  selector: 'my-menu',
  templateUrl: './menu.component.html',
  styleUrls: [ './menu.component.scss' ],
  standalone: true,
        Severity: Major
        Found in client/src/app/menu/menu.component.ts and 5 other locations - About 40 mins to fix
        client/src/app/+admin/system/jobs/jobs.component.ts on lines 20..189
        client/src/app/+my-account/my-account-settings/my-account-settings.component.ts on lines 21..104
        client/src/app/+videos/+video-watch/shared/comment/video-comment-add.component.ts on lines 34..251
        client/src/app/+videos/+video-watch/shared/comment/video-comments.component.ts on lines 20..323
        client/src/app/shared/shared-instance/instance-about-accordion.component.ts on lines 19..121

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status