Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/app/menu/notification-dropdown.component.ts

Summary

Maintainability
A
1 hr
Test Coverage

Function subscribeToNotifications has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  private async subscribeToNotifications () {
    const obs = await this.peertubeSocket.getMyNotificationsSocket()

    this.notificationSub = obs.subscribe(data => {
      if (data.type === 'new') return this.unreadNotifications++
Severity: Minor
Found in client/src/app/menu/notification-dropdown.component.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

  constructor (
    private userNotificationService: UserNotificationService,
    private screenService: ScreenService,
    private peertubeSocket: PeerTubeSocket,
    private notifier: Notifier,
Severity: Major
Found in client/src/app/menu/notification-dropdown.component.ts and 14 other locations - About 55 mins to fix
client/src/app/+accounts/account-video-channels/account-video-channels.component.ts on lines 65..71
client/src/app/+my-account/my-account-applications/my-account-applications.component.ts on lines 22..28
client/src/app/+my-account/my-account-import-export/my-account-import.component.ts on lines 38..44
client/src/app/+my-account/my-account-settings/my-account-danger-zone/my-account-danger-zone.component.ts on lines 12..18
client/src/app/+my-account/my-account-settings/my-account-two-factor/my-account-two-factor.component.ts on lines 39..46
client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts on lines 63..69
client/src/app/+signup/+register/register.component.ts on lines 82..88
client/src/app/+signup/+verify-account/verify-account-email/verify-account-email.component.ts on lines 28..35
client/src/app/+videos/video-list/video-user-subscriptions.component.ts on lines 38..46
client/src/app/core/theme/theme.service.ts on lines 24..30
client/src/app/shared/shared-main/users/user-notification.service.ts on lines 16..22
client/src/app/shared/shared-search/search.service.ts on lines 25..31
client/src/app/shared/shared-user-subscription/subscribe-button.component.ts on lines 48..54
client/src/app/shared/shared-video-miniature/download/video-download.component.ts on lines 52..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

@Component({
  selector: 'my-notification-dropdown',
  templateUrl: './notification-dropdown.component.html',
  styleUrls: [ './notification-dropdown.component.scss' ],
  standalone: true,
Severity: Major
Found in client/src/app/menu/notification-dropdown.component.ts and 11 other locations - About 30 mins to fix
client/src/app/+about/about-instance/about-instance.component.ts on lines 16..115
client/src/app/+admin/plugins/plugin-list-installed/plugin-list-installed.component.ts on lines 17..216
client/src/app/+my-account/my-account-import-export/my-account-export.component.ts on lines 14..128
client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 19..225
client/src/app/+videos/+video-watch/shared/recommendations/recommended-videos.component.ts on lines 14..108
client/src/app/shared/shared-forms/advanced-input-filter.component.ts on lines 25..187
client/src/app/shared/shared-forms/dynamic-form-field.component.ts on lines 10..42
client/src/app/shared/shared-moderation/report-modals/account-report.component.ts on lines 19..111
client/src/app/shared/shared-moderation/report-modals/comment-report.component.ts on lines 19..110
client/src/app/shared/shared-user-settings/user-video-settings.component.ts on lines 17..153
client/src/app/shared/shared-video-miniature/download/video-download.component.ts on lines 20..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status