Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/app/shared/shared-user-settings/user-video-settings.component.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function updateDetails has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  updateDetails (onlyKeys?: string[]) {
    const nsfwPolicy = this.form.value['nsfwPolicy']
    const p2pEnabled = this.form.value['p2pEnabled']
    const autoPlayVideo = this.form.value['autoPlayVideo']
    const autoPlayNextVideo = this.form.value['autoPlayNextVideo']
Severity: Minor
Found in client/src/app/shared/shared-user-settings/user-video-settings.component.ts - About 1 hr to fix

    Function updateDetails has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      updateDetails (onlyKeys?: string[]) {
    const nsfwPolicy = this.form.value['nsfwPolicy']
    const p2pEnabled = this.form.value['p2pEnabled']
    const autoPlayVideo = this.form.value['autoPlayVideo']
    const autoPlayNextVideo = this.form.value['autoPlayNextVideo']
    Severity: Minor
    Found in client/src/app/shared/shared-user-settings/user-video-settings.component.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        this.userService.updateMyProfile(details)
      .subscribe({
        next: () => {
          this.authService.refreshUserInformation()
    Severity: Major
    Found in client/src/app/shared/shared-user-settings/user-video-settings.component.ts and 1 other location - About 3 hrs to fix
    client/src/app/shared/shared-user-settings/user-interface-settings.component.ts on lines 91..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

      constructor (
    protected formReactiveService: FormReactiveService,
    private authService: AuthService,
    private notifier: Notifier,
    private userService: UserService,
    Severity: Major
    Found in client/src/app/shared/shared-user-settings/user-video-settings.component.ts and 8 other locations - About 1 hr to fix
    client/src/app/+admin/moderation/registration-list/process-registration-modal.component.ts on lines 32..40
    client/src/app/+my-library/my-ownership/my-accept-ownership/my-accept-ownership.component.ts on lines 33..41
    client/src/app/+my-library/my-video-channel-syncs/my-video-channel-syncs.component.ts on lines 53..61
    client/src/app/+my-library/my-videos/modals/video-change-ownership.component.ts on lines 30..38
    client/src/app/+reset-password/reset-password.component.ts on lines 21..29
    client/src/app/+signup/+verify-account/verify-account-ask-send-email/verify-account-ask-send-email.component.ts on lines 21..29
    client/src/app/shared/shared-moderation/user-ban-modal.component.ts on lines 34..42
    client/src/app/shared/shared-video-playlist/video-add-to-playlist.component.ts on lines 78..86

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

    @Component({
  selector: 'my-user-video-settings',
  templateUrl: './user-video-settings.component.html',
  styleUrls: [ './user-video-settings.component.scss' ],
  standalone: true,
    Severity: Major
    Found in client/src/app/shared/shared-user-settings/user-video-settings.component.ts and 11 other locations - About 30 mins to fix
    client/src/app/+about/about-instance/about-instance.component.ts on lines 16..115
    client/src/app/+admin/plugins/plugin-list-installed/plugin-list-installed.component.ts on lines 17..216
    client/src/app/+my-account/my-account-import-export/my-account-export.component.ts on lines 14..128
    client/src/app/+video-studio/edit/video-studio-edit.component.ts on lines 19..225
    client/src/app/+videos/+video-watch/shared/recommendations/recommended-videos.component.ts on lines 14..108
    client/src/app/menu/notification-dropdown.component.ts on lines 13..112
    client/src/app/shared/shared-forms/advanced-input-filter.component.ts on lines 25..187
    client/src/app/shared/shared-forms/dynamic-form-field.component.ts on lines 10..42
    client/src/app/shared/shared-moderation/report-modals/account-report.component.ts on lines 19..111
    client/src/app/shared/shared-moderation/report-modals/comment-report.component.ts on lines 19..110
    client/src/app/shared/shared-video-miniature/download/video-download.component.ts on lines 20..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status