Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/app/shared/shared-video-playlist/video-add-to-playlist.component.ts

Summary

Maintainability
C
1 day
Test Coverage

File video-add-to-playlist.component.ts has 326 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import debug from 'debug'
import { Subject, Subscription } from 'rxjs'
import { debounceTime, filter } from 'rxjs/operators'
import { ChangeDetectionStrategy, ChangeDetectorRef, Component, Input, OnChanges, OnDestroy, OnInit, SimpleChanges } from '@angular/core'
import { AuthService, DisableForReuseHook, Notifier } from '@app/core'
Severity: Minor
Found in client/src/app/shared/shared-video-playlist/video-add-to-playlist.component.ts - About 3 hrs to fix

    VideoAddToPlaylistComponent has 29 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Component({
  selector: 'my-video-add-to-playlist',
  styleUrls: [ './video-add-to-playlist.component.scss' ],
  templateUrl: './video-add-to-playlist.component.html',
  changeDetection: ChangeDetectionStrategy.OnPush,
    Severity: Minor
    Found in client/src/app/shared/shared-video-playlist/video-add-to-playlist.component.ts - About 3 hrs to fix

      Function addVideoInPlaylist has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        private addVideoInPlaylist (playlist: PlaylistSummary, element: PlaylistElement) {
    const body: VideoPlaylistElementCreate = { videoId: this.video.id }

    if (element.startTimestamp) body.startTimestamp = element.startTimestamp
    if (element.stopTimestamp && element.stopTimestamp !== this.video.duration) body.stopTimestamp = element.stopTimestamp
      Severity: Minor
      Found in client/src/app/shared/shared-video-playlist/video-add-to-playlist.component.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function isOptionalRowDisplayed has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        private isOptionalRowDisplayed (playlist: PlaylistSummary) {
    const elements = playlist.elements.filter(e => e.enabled)

    if (elements.length > 1) return true
      Severity: Minor
      Found in client/src/app/shared/shared-video-playlist/video-add-to-playlist.component.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

        constructor (
    protected formReactiveService: FormReactiveService,
    private authService: AuthService,
    private notifier: Notifier,
    private videoPlaylistService: VideoPlaylistService,
      Severity: Major
      Found in client/src/app/shared/shared-video-playlist/video-add-to-playlist.component.ts and 8 other locations - About 1 hr to fix
      client/src/app/+admin/moderation/registration-list/process-registration-modal.component.ts on lines 32..40
      client/src/app/+my-library/my-ownership/my-accept-ownership/my-accept-ownership.component.ts on lines 33..41
      client/src/app/+my-library/my-video-channel-syncs/my-video-channel-syncs.component.ts on lines 53..61
      client/src/app/+my-library/my-videos/modals/video-change-ownership.component.ts on lines 30..38
      client/src/app/+reset-password/reset-password.component.ts on lines 21..29
      client/src/app/+signup/+verify-account/verify-account-ask-send-email/verify-account-ask-send-email.component.ts on lines 21..29
      client/src/app/shared/shared-moderation/user-ban-modal.component.ts on lines 34..42
      client/src/app/shared/shared-user-settings/user-video-settings.component.ts on lines 42..50

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          this.videoPlaylistService.listMyPlaylistWithCache(this.user, this.videoPlaylistSearch)
        .subscribe(playlistsResult => {
          this.playlistsData = playlistsResult.data

          this.videoPlaylistService.runVideoExistsInPlaylistCheck(this.video.id)
      Severity: Minor
      Found in client/src/app/shared/shared-video-playlist/video-add-to-playlist.component.ts and 1 other location - About 35 mins to fix
      client/src/app/shared/shared-video-playlist/video-add-to-playlist.component.ts on lines 97..102

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          this.videoPlaylistService.listenToMyAccountPlaylistsChange()
        .subscribe(result => {
          this.playlistsData = result.data

          this.videoPlaylistService.runVideoExistsInPlaylistCheck(this.video.id)
      Severity: Minor
      Found in client/src/app/shared/shared-video-playlist/video-add-to-playlist.component.ts and 1 other location - About 35 mins to fix
      client/src/app/shared/shared-video-playlist/video-add-to-playlist.component.ts on lines 145..150

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status