Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/assets/player/peertube-player.ts

Summary

Maintainability
D
2 days
Test Coverage

File peertube-player.ts has 409 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import './shared/context-menu'
import './shared/upnext/end-card'
import './shared/upnext/upnext-plugin'
import './shared/stats/stats-card'
import './shared/stats/stats-plugin'
Severity: Minor
Found in client/src/assets/player/peertube-player.ts - About 5 hrs to fix

    Function getVideojsOptions has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      getVideojsOptions (): videojs.PlayerOptions {
    const html5 = {
      preloadTextTracks: false,
      // Prevent a bug on iOS where the text tracks added by peertube plugin are removed on play
      // See https://github.com/Chocobozzz/PeerTube/issues/6351
    Severity: Major
    Found in client/src/assets/player/peertube-player.ts - About 2 hrs to fix

      Function getContextMenuOptions has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private getContextMenuOptions () {

    const content = () => {
      const self = this
      const player = this.player
      Severity: Minor
      Found in client/src/assets/player/peertube-player.ts - About 2 hrs to fix

        Function content has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            const content = () => {
      const self = this
      const player = this.player

      const shortUUID = self.currentLoadOptions.videoShortUUID
        Severity: Minor
        Found in client/src/assets/player/peertube-player.ts - About 1 hr to fix

          Function disposeDynamicPluginsIfNeeded has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            private disposeDynamicPluginsIfNeeded () {
    if (!this.player) return

    if (this.player.usingPlugin('peertubeMobile')) this.player.peertubeMobile().dispose()
    if (this.player.usingPlugin('peerTubeHotkeysPlugin')) this.player.peerTubeHotkeysPlugin().dispose()
          Severity: Minor
          Found in client/src/assets/player/peertube-player.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function loadDynamicPlugins has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            private loadDynamicPlugins () {
    if (isMobile()) this.player.peertubeMobile()

    this.player.bezels()
          Severity: Minor
          Found in client/src/assets/player/peertube-player.ts - About 1 hr to fix

            Function buildPlayerIfNeeded has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              private async buildPlayerIfNeeded () {
    if (this.player) return

    await TranslationsManager.loadLocaleInVideoJS(this.options.serverUrl, this.options.language, videojs)
            Severity: Minor
            Found in client/src/assets/player/peertube-player.ts - About 1 hr to fix

              Function loadDynamicPlugins has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                private loadDynamicPlugins () {
    if (isMobile()) this.player.peertubeMobile()

    this.player.bezels()
              Severity: Minor
              Found in client/src/assets/player/peertube-player.ts - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function tryToRecoverHLSError has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                private async tryToRecoverHLSError (err: any) {
    if (err.code === MediaError.MEDIA_ERR_DECODE) {

      // Display a notification to user
      if (this.videojsDecodeErrors === 0) {
              Severity: Minor
              Found in client/src/assets/player/peertube-player.ts - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  this.player.stats({
      videoUUID: this.currentLoadOptions.videoUUID,
      videoIsLive: this.currentLoadOptions.isLive,
      mode: this.currentLoadOptions.mode,
      p2pEnabled: this.currentLoadOptions.p2pEnabled
              Severity: Minor
              Found in client/src/assets/player/peertube-player.ts and 1 other location - About 55 mins to fix
              client/src/app/+videos/+video-edit/video-update.component.ts on lines 239..244

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status